[40213] in SIPB bug reports
Re: Fixed a bug in whats.pl
daemon@ATHENA.MIT.EDU (Ken T Takusagawa)
Tue Nov 16 17:29:37 2010
From kenta@MIT.EDU Tue Nov 16 22:29:36 2010
Return-Path: <kenta@MIT.EDU>
Delivered-To: bug-sipb-mtg@CHARON.mit.edu
Received: (qmail 23635 invoked from network); 16 Nov 2010 22:29:36 -0000
Received: from mailhub-auth-4.mit.edu (18.7.62.39)
by charon.mit.edu with SMTP; 16 Nov 2010 22:29:36 -0000
Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id oAGMTZ9M010838;
Tue, 16 Nov 2010 17:29:35 -0500
Received: from localhost (CONTENTS-VNDER-PRESSVRE.MIT.EDU [18.9.64.11])
(authenticated bits=0)
(User authenticated as kenta@ATHENA.MIT.EDU)
by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id oAGMTYkr006073;
Tue, 16 Nov 2010 17:29:35 -0500 (EST)
Date: Tue, 16 Nov 2010 17:29:34 -0500 (EST)
From: Ken T Takusagawa <kenta@MIT.EDU>
To: bug-sipb@mit.edu, sipb-whats@mit.edu
Subject: Re: Fixed a bug in whats.pl
In-Reply-To: <alpine.DEB.2.00.1011161724120.1210@contents-vnder-pressvre.mit.edu>
Message-ID: <alpine.DEB.2.00.1011161728470.1210@contents-vnder-pressvre.mit.edu>
References: <alpine.DEB.2.00.1011161724120.1210@contents-vnder-pressvre.mit.edu>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Hmmm, I just realized that my change makes it no longer
possible to specify perl regular expressions as part of the
"whats" query. Was that a feature we wished to support?
--ken
--
Sent from a Dell 1950 8 CPU 32 GB RAM
On Tue, 16 Nov 2010, Ken T Takusagawa wrote:
> The acronym *$ broke whats.pl, so I've fixed it. The change
> was
>
> --- /tmp/whats 2009-08-31 21:06:38.000000000 -0400
> +++ whats.pl 2010-11-16 17:15:45.000000000 -0500
> @@ -17,7 +17,11 @@
>
> foreach (@ACRON) {
> if (open(IN, $_)) {
> - push(@entries, grep(/^$a\t/i,<IN>));
> + while(<IN>){
> + next unless /^([^\t]+)\t/;
> + next unless (uc $1) eq $a;
> + push @entries,$_;
> + }
> close(IN);
> }
> }
>
> --ken
>
> --
> Sent from a Dell 1950 8 CPU 32 GB RAM
>
