[4336] in BarnOwl Developers
Re: [barnowl/barnowl] Load PAR only when a .par module is found (PR
daemon@ATHENA.MIT.EDU (Daniel JB Clark)
Wed Nov 4 04:41:23 2026
Date: Wed, 04 Nov 2026 01:41:17 -0800
From: Daniel JB Clark <notifications@github.com>
Reply-To: barnowl/barnowl <reply+ABCERSMLSMN4FKSXDZCWZMTLMRD33EVBNHHQAAAAAFYBGE5C@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/200@github.com>
----==_mimepart_6aeafdbdf18cc_ec12d874757
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
djbclark left a comment (barnowl/barnowl#200)
Updated this branch, new head 9a0ee4c. `t/moduleloader.t` failed 4 tests when Archive::Zip was installed but PAR was not. The skip check now requires PAR as well. I also added a test that a PAR load failure is reported and that unpacked modules still load. `make check` passes (543 tests).
Across all branches: master plus all ten open PRs combined passes `make check` (1,844 tests, up from 1,798).
--
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/200#issuecomment-6627644071
You are receiving this because you are subscribed to this thread.
Message ID: <barnowl/barnowl/pull/200/c6627644071@github.com>
----==_mimepart_6aeafdbdf18cc_ec12d874757
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; alig=
n-items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius=
:50%; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githu=
busercontent.com/u/131936?s=3D20&v=3D4" /><strong>djbclark</strong> l=
eft a comment <a href=3D"https://github.com/barnowl/barnowl/pull/200#issu=
ecomment-6627644071">(barnowl/barnowl#200)</a></div>
<p dir=3D"auto">Updated this branch, new head <a class=3D"commit-link" da=
ta-hovercard-type=3D"commit" data-hovercard-url=3D"https://github.com/bar=
nowl/barnowl/commit/9a0ee4c0a3c34c16cd43b20eb0c7e64ab7dd03f6/hovercard" h=
ref=3D"https://github.com/barnowl/barnowl/commit/9a0ee4c0a3c34c16cd43b20e=
b0c7e64ab7dd03f6"><tt>9a0ee4c</tt></a>. <code class=3D"notranslate">t/mod=
uleloader.t</code> failed 4 tests when Archive::Zip was installed but PAR=
was not. The skip check now requires PAR as well. I also added a test th=
at a PAR load failure is reported and that unpacked modules still load. <=
code class=3D"notranslate">make check</code> passes (543 tests).</p>
<p dir=3D"auto">Across all branches: master plus all ten open PRs combine=
d passes <code class=3D"notranslate">make check</code> (1,844 tests, up f=
rom 1,798).</p>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/ba=
rnowl/barnowl/pull/200?email_source=3Dnotifications&email_token=3DABC=
ERSIN5GAMUNI3A5RVNUL5XL2T3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW=
2ZLOOQXTMNRSG43DINBQG4Y2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXE=
X3DNRUWG2Y#issuecomment-6627644071">view it on GitHub</a>, or <a href=3D"=
https://github.com/notifications/unsubscribe-auth/ABCERSKHVT2BM63QTUUMB3T=
5XL2T3AVCNFSNUABCKJSXA33TNF2G64TZHM3TINZTGA4TWSLTON2WKOZWGE3TKMRWGU3DSOFB=
OYBA">unsubscribe</a>.<br />Triage notifications, keep track of coding ag=
ent tasks and review pull requests on the go with GitHub Mobile for <a hr=
ef=3D"https://github.com/notifications/mobile/ios/ABCERSJE33I6IR45QLEHZF3=
5XL2T3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRSG43DINBQ=
G4Y2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ">iOS</a> and=
<a href=3D"https://github.com/notifications/mobile/android/ABCERSL3UZTGH=
UO5JIC6VD35XL2T3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMN=
RSG43DINBQG4Y2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33=
JMQ">Android</a>. Download it today!
<br />You are receiving this because you are subscribed to this thread.<i=
mg src=3D"https://github.com/notifications/beacon/ABCERSLYK7B6FSL5BSXDIQT=
5XL2T3BFCNFSM6AAAAADEDMNKJ6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3P=
NVWWK3TUL5UWJTYAAAAADCYJ2KT2M4TFMFZW63VKON2WE43DOJUWEZLE.gif" height=3D"1=
" width=3D"1" alt=3D"" /><span style=3D"color: transparent; font-size: 0;=
display: none; visibility: hidden; overflow: hidden; opacity: 0; width: =
0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <sp=
an><barnowl/barnowl/pull/200/c6627644071</span><span>@</span><span>git=
hub</span><span>.</span><span>com></span></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/barnowl/barnowl/pull/200?email_source=3Dnot=
ifications\u0026email_token=3DABCERSNYU63S3Y5J5BE5MYT5XL2T3A5CNFSNUABFM5U=
WIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRSG43DINBQG4Y2M4TFMFZW63VKON2W=
E43DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6627644071",
"url": "https://github.com/barnowl/barnowl/pull/200?email_source=3Dnotifi=
cations\u0026email_token=3DABCERSNYU63S3Y5J5BE5MYT5XL2T3A5CNFSNUABFM5UWIO=
RPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRSG43DINBQG4Y2M4TFMFZW63VKON2WE43=
DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#issuecomment-6627644071",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_6aeafdbdf18cc_ec12d874757--
