[4305] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

Re: [barnowl/barnowl] Six small fixes for bugs in master (logging

daemon@ATHENA.MIT.EDU (Jason Gross)
Tue Nov 3 01:51:09 2026

Date: Mon, 02 Nov 2026 22:51:03 -0800
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+ABCERSPDAO2C6IGQ2IVLZK3LMLHFNEVBNHHQAAAAAFXGMU3Z@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/190@github.com>


----==_mimepart_6ae984571b80_c512d0395952
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@JasonGross approved this pull request.

At a skim, this looks basically good to me.  If you have tested all of these commits, I'm inclined to merge



-- 
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/190#pullrequestreview-5748202721
You are receiving this because you are subscribed to this thread.

Message ID: <barnowl/barnowl/pull/190/review/5748202721@github.com>
----==_mimepart_6ae984571b80_c512d0395952
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p></p>
<p><b>@JasonGross</b> approved this pull request.</p>

<p dir=3D"auto">At a skim, this looks basically good to me.  If you have =
tested all of these commits, I'm inclined to merge</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/ba=
rnowl/barnowl/pull/190?email_source=3Dnotifications&amp;email_token=3DABC=
ERSKWAVVNA7KUZUOQE6D5XF55PA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2W=
K43UKJSXM2LFO4XTKNZUHAZDAMRXGIY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM=
33PORSXEX3DNRUWG2Y#pullrequestreview-5748202721">view it on GitHub</a>, o=
r <a href=3D"https://github.com/notifications/unsubscribe-auth/ABCERSMDAD=
WCJLRJHM4PIND5XF55PAVCNFSNUABCKJSXA33TNF2G64TZHM3TINZTGA4TWSLTON2WKOZWGE2=
DOMJWG4YDSN5BOYBA">unsubscribe</a>.<br />Triage notifications, keep track=
 of coding agent tasks and review pull requests on the go with GitHub Mob=
ile for <a href=3D"https://github.com/notifications/mobile/ios/ABCERSITWY=
YSBQW3FIPBOVD5XF55PA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJS=
XM2LFO4XTKNZUHAZDAMRXGIY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSX=
EX3JN5ZQ">iOS</a> and <a href=3D"https://github.com/notifications/mobile/=
android/ABCERSO6K73L2SBHGLHYMWD5XF55PA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QO=
VWGYUTFOF2WK43UKJSXM2LFO4XTKNZUHAZDAMRXGIY2M4TFMFZW63VKON2WE43DOJUWEZLEUV=
SXMZLOOSXGM33PORSXEX3BNZSHE33JMQ">Android</a>. Download it today!
<br />You are receiving this because you are subscribed to this thread.<i=
mg src=3D"https://github.com/notifications/beacon/ABCERSMW5S5COYCNCLSVHVL=
5XF55PBFCNFSM6AAAAADD6IIYOGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJ=
MV32UY3PNVWWK3TUL5UWJTYAAAAACVU6TTQ2M4TFMFZW63VKON2WE43DOJUWEZLE.gif" hei=
ght=3D"1" width=3D"1" alt=3D"" /><span style=3D"color: transparent; font-=
size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0;=
 width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message=
 ID: <span>&lt;barnowl/barnowl/pull/190/review/5748202721</span><span>@</=
span><span>github</span><span>.</span><span>com&gt;</span></span></p>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/barnowl/barnowl/pull/190?email_source=3Dnot=
ifications\u0026email_token=3DABCERSLN27MTNWP6BNDBBYD5XF55PA5CNFSNUABKM5U=
WIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKNZUHAZDAMRXGIY2M4TFMFZW=
63VKON2WE43DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#pullrequestreview-57482=
02721",
"url": "https://github.com/barnowl/barnowl/pull/190?email_source=3Dnotifi=
cations\u0026email_token=3DABCERSLN27MTNWP6BNDBBYD5XF55PA5CNFSNUABKM5UWIO=
RPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKNZUHAZDAMRXGIY2M4TFMFZW63V=
KON2WE43DOJUWEZLEUVSXMZLOOSVWO3LBNFWF6Y3MNFRWW#pullrequestreview-57482027=
21",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>=

----==_mimepart_6ae984571b80_c512d0395952--

home help back first fref pref prev next nref lref last post