[4170] in BarnOwl Developers
Re: [barnowl/barnowl] Experimental Zulip support (#184)
daemon@ATHENA.MIT.EDU (Adam Glasgall)
Tue Oct 17 03:11:02 2017
Date: Tue, 17 Oct 2017 03:55:05 +0000 (UTC)
From: Adam Glasgall <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c92b3e6347520b0335d7bf3b7344cb0dd20cb27cf292cf0000000115fd411892a169ce0fd8a3d7@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/184@github.com>
----==_mimepart_59e57f18e151d_1b533fd66b340f2c546e9
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
aglasgall commented on this pull request.
> + if( exists $raw_cfg->{ssl}) {
+ # mandatory parameters
+ if (! exists $raw_cfg->{ssl}->{ca_file}) {
+ fail("SSL parameters specified, but no CA file set");
+ }
+ $cfg{'ssl_ca_file'} = $raw_cfg->{ssl}->{ca_file};
+ $cfg{'ssl_verify'} = 1;
+ # optional parameters
+ if ( (exists $raw_cfg->{ssl}->{cert_file}) && exists $raw_cfg->{ssl}->{key_file}) {
+ $cfg{'ssl_cert_file'} = $raw_cfg->{ssl}->{cert_file};
+ $cfg{'ssl_key_file'} = $raw_cfg->{ssl}->{key_file};
+ } else {
+ warn "SSL parameters specified, but no client credentials set.";
+ }
+ } else {
+ $cfg{'ssl_verify'} = 0;
You are, of course, correct. I'm rewriting this, especially in light of the belated discovery that with no CA file specified, AnyEvent will use a platform-dependent default.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/184#discussion_r145022576
----==_mimepart_59e57f18e151d_1b533fd66b340f2c546e9
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p><b>@aglasgall</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/barnowl/barnowl/pull/184#discussion_r145022576">perl/modules/Zulip/lib/BarnOwl/Module/Zulip.pm</a>:</p>
<pre style='color:#555'>> + if( exists $raw_cfg->{ssl}) {
+ # mandatory parameters
+ if (! exists $raw_cfg->{ssl}->{ca_file}) {
+ fail("SSL parameters specified, but no CA file set");
+ }
+ $cfg{'ssl_ca_file'} = $raw_cfg->{ssl}->{ca_file};
+ $cfg{'ssl_verify'} = 1;
+ # optional parameters
+ if ( (exists $raw_cfg->{ssl}->{cert_file}) && exists $raw_cfg->{ssl}->{key_file}) {
+ $cfg{'ssl_cert_file'} = $raw_cfg->{ssl}->{cert_file};
+ $cfg{'ssl_key_file'} = $raw_cfg->{ssl}->{key_file};
+ } else {
+ warn "SSL parameters specified, but no client credentials set.";
+ }
+ } else {
+ $cfg{'ssl_verify'} = 0;
</pre>
<p>You are, of course, correct. I'm rewriting this, especially in light of the belated discovery that with no CA file specified, AnyEvent will use a platform-dependent default.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/184#discussion_r145022576">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyQXXehHz08hvKPMkTkvDbJ6iDIwxks5stCUYgaJpZM4P6_o2">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIyedC-ho27PX3vskGF_nJKxIWP35Wks5stCUYgaJpZM4P6_o2.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/184#discussion_r145022576"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@aglasgall commented on #184"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/184#discussion_r145022576"}}}</script>
----==_mimepart_59e57f18e151d_1b533fd66b340f2c546e9--
