[4158] in BarnOwl Developers
=?UTF-8?Q?[barnowl/barnowl]_09530e:_owl=5Fperlconfig=5Fhashr?=
daemon@ATHENA.MIT.EDU (GitHub)
Sun Oct 8 19:43:57 2017
Date: Sun, 08 Oct 2017 15:04:37 -0700
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu
----==_mimepart_59daa0f57eb98_9093f86f84ffc2c993cd
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 09530e6d0cb0cc0fffc24ff054dc0c301097f3e5
https://github.com/barnowl/barnowl/commit/09530e6d0cb0cc0fffc24ff05=
4dc0c301097f3e5
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2017-10-07 (Sat, 07 Oct 2017)
Changed paths:
M perlconfig.c
Log Message:
-----------
owl_perlconfig_hashref2message: Don=E2=80=99t pass uninitialized tm_isd=
st to mktime
strptime doesn=E2=80=99t initialize tm_isdst, so mktime was offsetting th=
e
time by =C2=B11 hour depending on uninitialized memory. Initializing
tm_isdst to a negative value causes it to guess. It will still guess
incorrectly during one hour of every year, but at least now the
behavior is defined.
(Discovered by valgrind.)
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Commit: ee6b30fb51d9d316db901c36a13af75b26719074
https://github.com/barnowl/barnowl/commit/ee6b30fb51d9d316db901c36a=
13af75b26719074
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2017-10-08 (Sun, 08 Oct 2017)
Changed paths:
M functions.c
M message.c
M zephyr.c
Log Message:
-----------
Avoid thread-unsafe functions ctime, localtime, strtok
BarnOwl seems to be growing threads at an alarming rate, so let=E2=80=99s=
be
sure these don=E2=80=99t turn into race conditions.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Compare: https://github.com/barnowl/barnowl/compare/0c059f0fccba...ee6b30=
fb51d9=
----==_mimepart_59daa0f57eb98_9093f86f84ffc2c993cd--
