[4148] in BarnOwl Developers
[barnowl/barnowl] Rename owl_log_entry_free to owl_log_entry_delete
daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Sat Oct 7 03:17:22 2017
Date: Sat, 07 Oct 2017 06:33:47 +0000 (UTC)
From: Anders Kaseorg <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c98b3772764799fb7b50efe25955868bc0320ba49492cf0000000115f0374b92a169ce0fb6898a@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
----==_mimepart_59d8754b5f7ed_56de3ffc94ed8f3453642
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
We use =E2=80=9C_cleanup=E2=80=9D for functions that free everything refere=
nced by the object and =E2=80=9C_delete=E2=80=9D for functions that also fr=
ee the object itself, avoiding the ambiguous =E2=80=9C_free=E2=80=9D.
Also remove the NULL check since the pointer can never be NULL.
You can view, comment on, or merge this pull request online at:
https://github.com/barnowl/barnowl/pull/181
-- Commit Summary --
* Rename owl_log_entry_free to owl_log_entry_delete
-- File Changes --
M logging.c (22)
-- Patch Links --
https://github.com/barnowl/barnowl/pull/181.patch
https://github.com/barnowl/barnowl/pull/181.diff
--=20
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/181
----==_mimepart_59d8754b5f7ed_56de3ffc94ed8f3453642
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<p>We use =E2=80=9C_cleanup=E2=80=9D for functions that free everything ref=
erenced by the object and =E2=80=9C_delete=E2=80=9D for functions that also=
free the object itself, avoiding the ambiguous =E2=80=9C_free=E2=80=9D.</p>
<p>Also remove the NULL check since the pointer can never be NULL.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href=3D'https://github.com/barnowl/barnowl/pull/181'>http=
s://github.com/barnowl/barnowl/pull/181</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Rename owl_log_entry_free to owl_log_entry_delete</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/181/files#diff-0">lo=
gging.c</a>
(22)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href=3D'https://github.com/barnowl/barnowl/pull/181.patch'>https:/=
/github.com/barnowl/barnowl/pull/181.patch</a></li>
<li><a href=3D'https://github.com/barnowl/barnowl/pull/181.diff'>https://=
github.com/barnowl/barnowl/pull/181.diff</a></li>
</ul>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />You are receiving this because you are subscribed to this thread.<=
br />Reply to this email directly, <a href=3D"https://github.com/barnowl/ba=
rnowl/pull/181">view it on GitHub</a>, or <a href=3D"https://github.com/not=
ifications/unsubscribe-auth/AERIyYuu8aaGngZPEB4col_Xl9eP4Y9hks5spxtLgaJpZM4=
PxQKp">mute the thread</a>.<img alt=3D"" height=3D"1" src=3D"https://github=
.com/notifications/beacon/AERIyV6re17RX-g85f4gvsablYrVs-6eks5spxtLgaJpZM4Px=
QKp.gif" width=3D"1" /></p>
<div itemscope itemtype=3D"http://schema.org/EmailMessage">
<div itemprop=3D"action" itemscope itemtype=3D"http://schema.org/ViewAction=
">
<link itemprop=3D"url" href=3D"https://github.com/barnowl/barnowl/pull/18=
1"></link>
<meta itemprop=3D"name" content=3D"View Pull Request"></meta>
</div>
<meta itemprop=3D"description" content=3D"View this Pull Request on GitHub"=
></meta>
</div>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_version"=
:"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"Gi=
tHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/b=
arnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.gith=
ubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7b=
b5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/1434=
18/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Ope=
n in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snipp=
ets":[{"icon":"DESCRIPTION","message":"Rename owl_log_entry_free to owl_log=
_entry_delete (#181)"}],"action":{"name":"View Pull Request","url":"https:/=
/github.com/barnowl/barnowl/pull/181"}}}</script>
----==_mimepart_59d8754b5f7ed_56de3ffc94ed8f3453642--
