[4140] in BarnOwl Developers
Current Barnowl PRs
daemon@ATHENA.MIT.EDU (Alex Dehnert)
Sun Aug 20 18:37:41 2017
Date: Sun, 20 Aug 2017 18:37:36 -0400 (EDT)
From: Alex Dehnert <adehnert@mit.edu>
To: barnowl-dev@mit.edu
Here's a summary of the state of the current PRs, AFAICT. (I'm mostly
writing this email on the theory that I should record this *somewhere*,
and mail to barnowl-dev seems as good a place as any.)
Load Jabber module lazily
#91 opened on Mar 14, 2012 by davidben
Not currently mergeable, due to (I assume) more recent Jabber changes. I
haven't looked at the code, but it seems reasonably likely to be easy to
fix. Deferred module loading does seem like a good idea if the startup
difference is as big as David suggests.
Add command to get a Jabber buddy's status
#145 opened on Aug 8, 2013 by ezyang
3
There's a partial review with some negative comments. We could probably
fix it up, but there'd be some effort, I think.
Reimplement message list attributes as GLib data list
#158 opened on Dec 25, 2013 by andersk
2
Anders indicates on the PR that he's not sure we should merge it.
Implement proper Twitter at-reply prefill semantics, and other
miscellaneous fixes
#162 opened on Mar 22, 2014 by ezyang
2
First three (of four) commits have a positive review from Anders. I've
redone commit 4 per Anders' request as PR #177. If somebody else wants to
review that, I think it'd be fine to merge. (Or I probably will if nobody
touches it for a couple weeks.) I'm not sure twitter sending actually
works, but it's not like these changes make it work *worse* particularly.
rewrite zephyr scribelike markup parsing
#172 opened on Mar 15, 2016 by kcr
5
Anders raised concerns about performance, and suggested benchmarking it.
zephyr_zwrite: Use owl_function_zwrite
#173 opened on Mar 16, 2016 by andersk
2
Positive review from Karl; I'm not sure why Anders or Karl haven't merged
it.
Fix M-LEFT binding, and also bind C-LEFT, C-RIGHT
#174 opened on Aug 26, 2016 by andersk
2
Basically positive review from Jason; I'm not sure why Anders hasn't
merged it already. (I think Jason has indicated that he was deferring to
Anders.)
PR #162, except putting the tweet URL in the :info popup
#177 opened 23 minutes ago by dehnert
New fix of PR #162. I think it'd be fine to review, but somebody else
should review it or I need to wait out the timeout.
Basically, my inclination is that #173, #174, and #177 should be merged.
#91 should probably get some work to update it (and an actual review) and
then get (maybe) merged. #172 should get benchmarked (and more of a
review) and then merged. #145 and #158 could get the comments fixed and be
merged, but don't seem clearly worth the effort. #162 should get closed as
obsolete when #177 gets merged.
My personal hope is to get these resolved and merge Adam's zulip work, and
then put out a new barnowl release. I'll probably try to put out a
barnowl-beta at some point with these (possibly pre-merge) for testing.
~~Alex
