[4125] in BarnOwl Developers
Re: [barnowl/barnowl] Perl logging (#54)
daemon@ATHENA.MIT.EDU (Alex Dehnert)
Sun Aug 6 01:44:53 2017
Date: Sat, 05 Aug 2017 22:44:51 -0700
From: Alex Dehnert <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c95c227c19dc34a9a2d804d07e45b345089ef7e16492cf00000001159e6ed392a169ce00127fe9@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: barnowl-dev email-only account <barnowl-dev@mit.edu>,
Comment <comment@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/54@github.com>
----==_mimepart_5986acd32e6d2_79763fd2870a7c309818c
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
dehnert commented on this pull request.
> + * propose compat_casefold. And I guess if Jabber wants it too, we should
+ * move it to util.c.
+ */
+ char *tmp0 = g_utf8_normalize(str, -1, G_NORMALIZE_NFD);
+ char *tmp1 = g_utf8_casefold(tmp0, -1);
+ char *tmp2 = g_utf8_normalize(tmp1, -1, G_NORMALIZE_NFKD);
+ char *tmp3 = g_utf8_casefold(tmp2, -1);
+ char *out = g_utf8_normalize(tmp3, -1, G_NORMALIZE_NFKC);
+ g_free(tmp0);
+ g_free(tmp1);
+ g_free(tmp2);
+ g_free(tmp3);
+
+ return out;
+}
+
@andersk , can you review this function?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/54#pullrequestreview-54527777
----==_mimepart_5986acd32e6d2_79763fd2870a7c309818c
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p><b>@dehnert</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534810">util.c</a>:</p>
<pre style='color:#555'>> + * propose compat_casefold. And I guess if Jabber wants it too, we should
+ * move it to util.c.
+ */
+ char *tmp0 = g_utf8_normalize(str, -1, G_NORMALIZE_NFD);
+ char *tmp1 = g_utf8_casefold(tmp0, -1);
+ char *tmp2 = g_utf8_normalize(tmp1, -1, G_NORMALIZE_NFKD);
+ char *tmp3 = g_utf8_casefold(tmp2, -1);
+ char *out = g_utf8_normalize(tmp3, -1, G_NORMALIZE_NFKC);
+ g_free(tmp0);
+ g_free(tmp1);
+ g_free(tmp2);
+ g_free(tmp3);
+
+ return out;
+}
+
</pre>
<p><a href="https://github.com/andersk" class="user-mention">@andersk</a> , can you review this function?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/54#pullrequestreview-54527777">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyXmMk2FGO-ESoLs0Os36lazem0Caks5sVVLTgaJpZM4BW8Zd">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIyT2kqK9ZBXSLDKhleLyY8zQUTF-4ks5sVVLTgaJpZM4BW8Zd.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/54#pullrequestreview-54527777"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@dehnert commented on #54"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/54#pullrequestreview-54527777"}}}</script>
----==_mimepart_5986acd32e6d2_79763fd2870a7c309818c--
