[4113] in BarnOwl Developers
Re: [barnowl/barnowl] Perl logging (#54)
daemon@ATHENA.MIT.EDU (Jason Gross)
Sun Aug 6 01:13:16 2017
Date: Sat, 05 Aug 2017 22:13:11 -0700
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c9b773e03c881088bdeb8a2c0b2cd023664fbfa05492cf00000001159e676792a169ce00127fe9@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: barnowl-dev email-only account <barnowl-dev@mit.edu>,
Comment <comment@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/54@github.com>
----==_mimepart_5986a567c62b4_533a3fd4c772dc34211c3
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
JasonGross commented on this pull request.
> + return $m->log_header . "\n\n" . $m->log_body . "\n\n";
+}
+
+=head2 log_header MESSAGE
+
+Returns the header of the message, for logging purposes.
+If you override L<BarnOwl::Message::log>, this method is not called.
+
+=cut
+
+sub log_header {
+ my ($m) = @_;
+ my $sender = $m->sender;
+ my $recipient = $m->recipient;
+ my $timestr = $m->time;
+ return "From: <$sender> To: <$recipient>\n"
What do you mean by "Should"? This is the format that was already present in `owl_log_generic`. Whether or not that format is "good" is a different matter.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/54#discussion_r131534504
----==_mimepart_5986a567c62b4_533a3fd4c772dc34211c3
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p><b>@JasonGross</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534504">perl/lib/BarnOwl/Message.pm</a>:</p>
<pre style='color:#555'>> + return $m->log_header . "\n\n" . $m->log_body . "\n\n";
+}
+
+=head2 log_header MESSAGE
+
+Returns the header of the message, for logging purposes.
+If you override L<BarnOwl::Message::log>, this method is not called.
+
+=cut
+
+sub log_header {
+ my ($m) = @_;
+ my $sender = $m->sender;
+ my $recipient = $m->recipient;
+ my $timestr = $m->time;
+ return "From: <$sender> To: <$recipient>\n"
</pre>
<p>What do you mean by "Should"? This is the format that was already present in <code>owl_log_generic</code>. Whether or not that format is "good" is a different matter.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534504">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyb-zF395-ZuN8ux6CEUa-DAUsxBdks5sVUtngaJpZM4BW8Zd">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIyeabse_j1824XCrcwQhIP41xNHqKks5sVUtngaJpZM4BW8Zd.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/54#discussion_r131534504"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@JasonGross commented on #54"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/54#discussion_r131534504"}}}</script>
----==_mimepart_5986a567c62b4_533a3fd4c772dc34211c3--
