[4099] in BarnOwl Developers
Re: [barnowl/barnowl] Defer failed log messages (#109)
daemon@ATHENA.MIT.EDU (Jason Gross)
Sat Aug 5 22:18:58 2017
Date: Sun, 06 Aug 2017 02:18:55 +0000 (UTC)
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c9cadefb78776ba2e9a860df915545b8b7d1f986bd92cf00000001159e3e8f92a169ce009427d1@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/109@github.com>
----==_mimepart_59867c8fb9f3c_6baa3f9f90c0dc344129
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
JasonGross commented on this pull request.
> + } else if (ret != 0) {
+ owl_log_file_error(msg, ret);
+ }
+ }
+}
+
+/* tries to write the deferred log entries */
+static void owl_log_write_deferred_entries(gpointer data)
+{
+ owl_log_entry *entry;
+ bool drop_failed_logs = *(bool *)data;
+ int ret;
+ int logged_message_count = 0;
+ bool all_succeeded = true;
+
+ defer_logs = false;
Comment added at declaration of `defer_logs`, and an `N.B` is added to each of the functions where this is accessed that access this variable; is that enough @adehnert?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/109#discussion_r131533132
----==_mimepart_59867c8fb9f3c_6baa3f9f90c0dc344129
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p><b>@JasonGross</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/barnowl/barnowl/pull/109#discussion_r131533132">logging.c</a>:</p>
<pre style='color:#555'>> + } else if (ret != 0) {
+ owl_log_file_error(msg, ret);
+ }
+ }
+}
+
+/* tries to write the deferred log entries */
+static void owl_log_write_deferred_entries(gpointer data)
+{
+ owl_log_entry *entry;
+ bool drop_failed_logs = *(bool *)data;
+ int ret;
+ int logged_message_count = 0;
+ bool all_succeeded = true;
+
+ defer_logs = false;
</pre>
<p>Comment added at declaration of <code>defer_logs</code>, and an <code>N.B</code> is added to each of the functions where this is accessed that access this variable; is that enough <a href="https://github.com/adehnert" class="user-mention">@adehnert</a>?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/barnowl/barnowl/pull/109#discussion_r131533132">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AERIyXprBbqApmqSFrVAXLv92pNx2sZbks5sVSKPgaJpZM4AWArI">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIyZvlh8vPMx2IfYmyIN68W49cbdYpks5sVSKPgaJpZM4AWArI.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/109#discussion_r131533132"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/barnowl/barnowl","title":"barnowl/barnowl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/barnowl/barnowl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@JasonGross commented on #109"}],"action":{"name":"View Pull Request","url":"https://github.com/barnowl/barnowl/pull/109#discussion_r131533132"}}}</script>
----==_mimepart_59867c8fb9f3c_6baa3f9f90c0dc344129--
