[4082] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 41677d: Fix :set usage string

daemon@ATHENA.MIT.EDU (GitHub)
Sat Aug 5 17:54:27 2017

Date: Sat, 05 Aug 2017 14:54:24 -0700
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu


----==_mimepart_59863e9024bfc_43a63fe996419c4420216f
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

  Branch: refs/heads/master
  Home:   https://github.com/barnowl/barnowl
  Commit: 41677d2de06d4665686302a8c5e27c26575bfb19
      https://github.com/barnowl/barnowl/commit/41677d2de06d4665686302a8c5e27c26575bfb19
  Author: David Benjamin <davidben@mit.edu>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M commands.c

  Log Message:
  -----------
  Fix :set usage string

Variable isn't optional. Rather either you pass no arguments or a bunch
of them.


  Commit: bf21c4e4ec3c2bd59437d516d673895961babe5f
      https://github.com/barnowl/barnowl/commit/bf21c4e4ec3c2bd59437d516d673895961babe5f
  Author: David Benjamin <davidben@mit.edu>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M perl/lib/BarnOwl/Complete/Client.pm

  Log Message:
  -----------
  Correct tab-completion for set/unset

They only allow -q at the front.


  Commit: a95b564a734e8e881713aff7bb20add013369253
      https://github.com/barnowl/barnowl/commit/a95b564a734e8e881713aff7bb20add013369253
  Author: David Benjamin <davidben@mit.edu>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M variable.c

  Log Message:
  -----------
  Descriptions should be empty, not NULL

It's annoying for code that assumes non-nullable string. Also we
actually hit a g_return_val_if_fail via g_string_append when
owl_variable_get_description is NULL.


  Commit: 81e93c3f36e771c0a9f117468434e187b3df7ca0
      https://github.com/barnowl/barnowl/commit/81e93c3f36e771c0a9f117468434e187b3df7ca0
  Author: David Benjamin <davidben@mit.edu>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M perlglue.xs
    M variable.c

  Log Message:
  -----------
  Add BarnOwl::get_variable_info

Returns a dictionary about a given variable.


  Commit: 1f92f3904ab3464a4e558e76661ad58771cf5a41
      https://github.com/barnowl/barnowl/commit/1f92f3904ab3464a4e558e76661ad58771cf5a41
  Author: David Benjamin <davidben@mit.edu>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M perl/lib/BarnOwl/Complete/Client.pm

  Log Message:
  -----------
  Revamp set/unset completion

- unset <tab> only completes takes_on_off variables
- Variables with validsettings <path> complete as file paths
- Variables with validsettings a comma-separated list of options
  complete appropriately.


Compare: https://github.com/barnowl/barnowl/compare/678a7650cf75...1f92f3904ab3
----==_mimepart_59863e9024bfc_43a63fe996419c4420216f--

home help back first fref pref prev next nref lref last post