[3939] in BarnOwl Developers
[barnowl] rewrite zephyr scribelike markup parsing (#172)
daemon@ATHENA.MIT.EDU (Karl Ramm)
Tue Mar 15 15:31:18 2016
Date: Tue, 15 Mar 2016 12:31:13 -0700
From: Karl Ramm <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c911ddec7d9839e19144bdcf935e8e0e7a5efdf2e592cf000000011300250192a169ce0868a710@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
----==_mimepart_56e863019ce7a_42d63fa433c472c0551ad
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
While investigating something that turned out to be trac ticket #188, I looked at owl_fmtext_append_ztext and found that I couldn't unsee it, so here's a parser with a state machine that produces a syntax tree, that then gets rendered into fmtext. This turned out not to fix the bug; herein also find a ztext_protect function that _can_ be used to fix the bug. Also a zwgc-style code strip (that doesn't just strip environments that barnowl understands) and support for @roman (remove bold and underline).
You can view, comment on, or merge this pull request online at:
https://github.com/barnowl/barnowl/pull/172
-- Commit Summary --
* rewrite the zephyr scribelike markup parser
* clean out some debug tooling
* more patterns I was feeling paranoid about
* Barnowl::ztext_protect ~ "protect() from zwgc.desc"
* Make ztext_strip do something more like zwgc does
* implement @roman style from zwgc
-- File Changes --
M AUTHORS (1)
M Makefile.am (2)
M fmtext.c (266)
M owl.h (1)
M perl/lib/BarnOwl.pm (10)
M perl/lib/BarnOwl/Style.pm (14)
M perlglue.xs (28)
M tester.c (183)
A ztext.c (299)
A ztext.h (25)
-- Patch Links --
https://github.com/barnowl/barnowl/pull/172.patch
https://github.com/barnowl/barnowl/pull/172.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/172
----==_mimepart_56e863019ce7a_42d63fa433c472c0551ad
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p>While investigating something that turned out to be trac ticket #188, I looked at owl_fmtext_append_ztext and found that I couldn't unsee it, so here's a parser with a state machine that produces a syntax tree, that then gets rendered into fmtext. This turned out not to fix the bug; herein also find a ztext_protect function that <em>can</em> be used to fix the bug. Also a zwgc-style code strip (that doesn't just strip environments that barnowl understands) and support for <a href="https://github.com/roman" class="user-mention">@roman</a> (remove bold and underline).</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/barnowl/barnowl/pull/172'>https://github.com/barnowl/barnowl/pull/172</a></p>
<h4>Commit Summary</h4>
<ul>
<li>rewrite the zephyr scribelike markup parser</li>
<li>clean out some debug tooling</li>
<li>more patterns I was feeling paranoid about</li>
<li>Barnowl::ztext_protect ~ "protect() from zwgc.desc"</li>
<li>Make ztext_strip do something more like zwgc does</li>
<li>implement @roman style from zwgc</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-0">AUTHORS</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-1">Makefile.am</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-2">fmtext.c</a>
(266)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-3">owl.h</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-4">perl/lib/BarnOwl.pm</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-5">perl/lib/BarnOwl/Style.pm</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-6">perlglue.xs</a>
(28)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-7">tester.c</a>
(183)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-8">ztext.c</a>
(299)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/barnowl/barnowl/pull/172/files#diff-9">ztext.h</a>
(25)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/barnowl/barnowl/pull/172.patch'>https://github.com/barnowl/barnowl/pull/172.patch</a></li>
<li><a href='https://github.com/barnowl/barnowl/pull/172.diff'>https://github.com/barnowl/barnowl/pull/172.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/barnowl/barnowl/pull/172">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AERIyXzHJySDL3HYfmp4kSn2673jOUbTks5ptwkBgaJpZM4HxXeZ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/172"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
----==_mimepart_56e863019ce7a_42d63fa433c472c0551ad--
