[3864] in BarnOwl Developers
[barnowl] Clean up ircnets on socketless disconnect (#167)
daemon@ATHENA.MIT.EDU (Jason Gross)
Mon Jul 13 13:00:40 2015
Date: Mon, 13 Jul 2015 10:00:38 -0700
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+004448c9467d5911450259f96f6de349a28aaa7bf1a0cca792cf0000000111bbb0b692a169ce05a6049c@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
----==_mimepart_55a3eeb69782f_46713f8b403f52b8516468
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
This allows recovery from the state that BarnOwl gets into when (I
think) a disconnect message from the server is dropped, and BarnOwl
thinks it's connected, and the IRC server thinks it's not, and so you
can neither disconnect nor reconnect.
You can view, comment on, or merge this pull request online at:
https://github.com/barnowl/barnowl/pull/167
-- Commit Summary --
* Clean up ircnets on socketless disconnect
-- File Changes --
M perl/modules/IRC/lib/BarnOwl/Module/IRC.pm (4)
-- Patch Links --
https://github.com/barnowl/barnowl/pull/167.patch
https://github.com/barnowl/barnowl/pull/167.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/167
----==_mimepart_55a3eeb69782f_46713f8b403f52b8516468
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p>This allows recovery from the state that BarnOwl gets into when (I<br>
think) a disconnect message from the server is dropped, and BarnOwl<br>
thinks it's connected, and the IRC server thinks it's not, and so you<br>
can neither disconnect nor reconnect.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/barnowl/barnowl/pull/167'>https://github.com/barnowl/barnowl/pull/167</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Clean up ircnets on socketless disconnect</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/barnowl/barnowl/pull/167/files#diff-0">perl/modules/IRC/lib/BarnOwl/Module/IRC.pm</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/barnowl/barnowl/pull/167.patch'>https://github.com/barnowl/barnowl/pull/167.patch</a></li>
<li><a href='https://github.com/barnowl/barnowl/pull/167.diff'>https://github.com/barnowl/barnowl/pull/167.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/barnowl/barnowl/pull/167">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AERIyYltEQ4ydgrG3DKaBdgTXBOZDBOmks5oc-Y2gaJpZM4FXmi6.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/barnowl/barnowl/pull/167"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
----==_mimepart_55a3eeb69782f_46713f8b403f52b8516468--
