[3774] in BarnOwl Developers
[barnowl/barnowl] cba6b9: owl_util_file_deleteline: Prevent FD leak
daemon@ATHENA.MIT.EDU (GitHub)
Mon May 5 06:49:05 2014
Date: Mon, 05 May 2014 03:49:00 -0700
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu
----==_mimepart_53676c9cc295f_9dc611d4027461
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: cba6b9cc47c8456903199355c4fc67c83a9ec030
https://github.com/barnowl/barnowl/commit/cba6b9cc47c8456903199355c4fc67c83a9ec030
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2014-04-23 (Wed, 23 Apr 2014)
Changed paths:
M util.c
Log Message:
-----------
owl_util_file_deleteline: Prevent FD leak in error paths
Found by Coverity Scan service.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Commit: b61ad80a8aa3cbe41688a74ec2933ed19b2d055d
https://github.com/barnowl/barnowl/commit/b61ad80a8aa3cbe41688a74ec2933ed19b2d055d
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2014-05-05 (Mon, 05 May 2014)
Changed paths:
M functions.c
Log Message:
-----------
owl_function_debugmsg: Be sure to match va_start with va_end
Found by Coverity Scan service.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Commit: 18380fd9f4b7c0abe68100856fa68f30a0eab188
https://github.com/barnowl/barnowl/commit/18380fd9f4b7c0abe68100856fa68f30a0eab188
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2014-05-05 (Mon, 05 May 2014)
Changed paths:
M zephyr.c
Log Message:
-----------
owl_zephyr_load{subs,loginsubs}: Eliminate useless stat call
Placates Coverity Scan service, which detects a TOCTOU race between
stat and fopen. This race was in fact hiding an unlikely memory leak.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Commit: 94b9ee074ae76ef2e585605ccf56f030d02378a6
https://github.com/barnowl/barnowl/commit/94b9ee074ae76ef2e585605ccf56f030d02378a6
Author: Anders Kaseorg <andersk@mit.edu>
Date: 2014-05-05 (Mon, 05 May 2014)
Changed paths:
M variable.c
Log Message:
-----------
owl_variable_bool_get_tostring_default: Remove dead <invalid> case
bool is 0 or 1. Found by Coverity Scan service.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Compare: https://github.com/barnowl/barnowl/compare/9ae6095ed62f...94b9ee074ae7
----==_mimepart_53676c9cc295f_9dc611d4027461--
