[3765] in BarnOwl Developers

home	help	back	first	fref	pref	prev	next	nref	lref	last	post

[barnowl] Fix issues found by Coverity Scan (#163)

daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Wed Apr 23 03:14:05 2014

Date: Wed, 23 Apr 2014 00:14:02 -0700
From: Anders Kaseorg <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-32037621-7d57d3e8ffed5b1b8616aea11f10e1fcfdf11747-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>


----==_mimepart_5357683a984dd_58773fdb8d73f2b4100981
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit


You can merge this Pull Request by running:

  git pull https://github.com/andersk/barnowl coverity

Or you can view, comment on it, or merge it online at:

  https://github.com/barnowl/barnowl/pull/163

-- Commit Summary --

  * filterproc: Simplify stdin closing condition
  * owl_util_file_deleteline: Prevent FD leak in error paths
  * owl_function_debugmsg: Be sure to match va_start with va_end
  * owl_zephyr_load{subs,loginsubs}: Eliminate useless stat call
  * owl_variable_bool_get_tostring_default: Remove dead &lt;invalid&gt; case

-- File Changes --

    M filterproc.c (11)
    M functions.c (7)
    M util.c (5)
    M variable.c (9)
    M zephyr.c (29)

-- Patch Links --

https://github.com/barnowl/barnowl/pull/163.patch
https://github.com/barnowl/barnowl/pull/163.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/163

----==_mimepart_5357683a984dd_58773fdb8d73f2b4100981
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit



<hr>

<h4>You can merge this Pull Request by running</h4>
<pre>  git pull https://github.com/andersk/barnowl coverity</pre>
<p>Or view, comment on, or merge it at:</p>
<p>&nbsp;&nbsp;<a href='https://github.com/barnowl/barnowl/pull/163'>https://github.com/barnowl/barnowl/pull/163</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>filterproc: Simplify stdin closing condition</li>
  <li>owl_util_file_deleteline: Prevent FD leak in error paths</li>
  <li>owl_function_debugmsg: Be sure to match va_start with va_end</li>
  <li>owl_zephyr_load{subs,loginsubs}: Eliminate useless stat call</li>
  <li>owl_variable_bool_get_tostring_default: Remove dead &lt;invalid&gt; case</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/barnowl/barnowl/pull/163/files#diff-0">filterproc.c</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/barnowl/barnowl/pull/163/files#diff-1">functions.c</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/barnowl/barnowl/pull/163/files#diff-2">util.c</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/barnowl/barnowl/pull/163/files#diff-3">variable.c</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/barnowl/barnowl/pull/163/files#diff-4">zephyr.c</a>
    (29)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/barnowl/barnowl/pull/163.patch'>https://github.com/barnowl/barnowl/pull/163.patch</a></li>
  <li><a href='https://github.com/barnowl/barnowl/pull/163.diff'>https://github.com/barnowl/barnowl/pull/163.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href='https://github.com/barnowl/barnowl/pull/163'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/4475081__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMzg1NjQ0MiwiZGF0YSI6eyJpZCI6MzA1ODgxMjJ9fQ==--925cd253e91abe33017e1972085ca959caa27fca.gif' height='1' width='1'></p>

----==_mimepart_5357683a984dd_58773fdb8d73f2b4100981--

home	help	back	first	fref	pref	prev	next	nref	lref	last	post