[3661] in BarnOwl Developers
[barnowl] Reimplement message list attributes as GLib data list
daemon@ATHENA.MIT.EDU (Anders Kaseorg)
Wed Dec 25 15:31:11 2013
Date: Wed, 25 Dec 2013 12:31:08 -0800
From: Anders Kaseorg <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-24772778-8f432967447fd93a15b33b0efa69dc7f2dfa2222-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
----==_mimepart_52bb408c11449_48c1b27cf891a
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Since GLib data list values are individually associated with destroy func=
tions, this lets message attributes share some data with ZNotice_t fields=
. (I=E2=80=99m not entirely sure whether this is a net win.)
You can merge this Pull Request by running:
git pull https://github.com/andersk/barnowl gdata
Or you can view, comment on it, or merge it online at:
https://github.com/barnowl/barnowl/pull/158
-- Commit Summary --
* Use the Glib slice allocator for fixed-size objects
* Use GData for message attributes
* Kill owl_pair
* owl_message_set_attribute: Take a destroy function for the value
-- File Changes --
M Makefile.am (2)
M aim.c (4)
M buddy.c (2)
M buddylist.c (6)
M cmd.c (8)
M context.c (4)
M editwin.c (8)
M filter.c (14)
M filterelement.c (4)
M functions.c (18)
M global.c (4)
M keybinding.c (8)
M keymap.c (2)
M logging.c (6)
M mainwin.c (2)
M message.c (273)
M messagelist.c (4)
M owl.h (7)
D pair.c (22)
M perlconfig.c (26)
M perlglue.xs (2)
M popexec.c (4)
M popwin.c (4)
M runtests.sh (1)
M select.c (4)
M style.c (2)
M tester.c (10)
M util.c (15)
M variable.c (4)
M viewwin.c (6)
M zephyr.c (12)
M zwrite.c (10)
-- Patch Links --
https://github.com/barnowl/barnowl/pull/158.patch
https://github.com/barnowl/barnowl/pull/158.diff
----==_mimepart_52bb408c11449_48c1b27cf891a
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<p>Since GLib data list values are individually associated with destroy f=
unctions, this lets message attributes share some data with ZNotice_t fie=
lds. (I=E2=80=99m not entirely sure whether this is a net win.)</p>
<hr>
<h4>You can merge this Pull Request by running</h4>
<pre> git pull https://github.com/andersk/barnowl gdata</pre>
<p>Or view, comment on, or merge it at:</p>
<p> <a href=3D'https://github.com/barnowl/barnowl/pull/158'>ht=
tps://github.com/barnowl/barnowl/pull/158</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Use the Glib slice allocator for fixed-size objects</li>
<li>Use GData for message attributes</li>
<li>Kill owl_pair</li>
<li>owl_message_set_attribute: Take a destroy function for the value</l=
i>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-0">=
Makefile.am</a>
(2)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-1">=
aim.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-2">=
buddy.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-3">=
buddylist.c</a>
(6)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-4">=
cmd.c</a>
(8)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-5">=
context.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-6">=
editwin.c</a>
(8)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-7">=
filter.c</a>
(14)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-8">=
filterelement.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-9">=
functions.c</a>
(18)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-10"=
>global.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-11"=
>keybinding.c</a>
(8)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-12"=
>keymap.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-13"=
>logging.c</a>
(6)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-14"=
>mainwin.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-15"=
>message.c</a>
(273)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-16"=
>messagelist.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-17"=
>owl.h</a>
(7)
</li>
<li>
<strong>D</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-18"=
>pair.c</a>
(22)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-19"=
>perlconfig.c</a>
(26)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-20"=
>perlglue.xs</a>
(2)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-21"=
>popexec.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-22"=
>popwin.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-23"=
>runtests.sh</a>
(1)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-24"=
>select.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-25"=
>style.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-26"=
>tester.c</a>
(10)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-27"=
>util.c</a>
(15)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-28"=
>variable.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-29"=
>viewwin.c</a>
(6)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-30"=
>zephyr.c</a>
(12)
</li>
<li>
<strong>M</strong>
<a href=3D"https://github.com/barnowl/barnowl/pull/158/files#diff-31"=
>zwrite.c</a>
(10)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href=3D'https://github.com/barnowl/barnowl/pull/158.patch'>https=
://github.com/barnowl/barnowl/pull/158.patch</a></li>
<li><a href=3D'https://github.com/barnowl/barnowl/pull/158.diff'>https:=
//github.com/barnowl/barnowl/pull/158.diff</a></li>
</ul>
----==_mimepart_52bb408c11449_48c1b27cf891a--
