[3583] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl] Unbreak connecting to Google / Facebook with XMPP (#149)

daemon@ATHENA.MIT.EDU (tehmoth)
Tue Sep 17 22:02:51 2013

Date: Tue, 17 Sep 2013 19:02:16 -0700
From: tehmoth <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-19658272-aeb917e5f0ab931d8ce399c36a39e9565f18d217-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>


----==_mimepart_523909a8a9972_13b3103bd3474431
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

Fix BarnOwl::Module::Jabber::getServerFromJID to use Net::DNS::RR::SRV methods instead of hash access (which seem to no longer work).  This unbreaks connecting via Jabber to Google or Facebook.
You can merge this Pull Request by running:

  git pull https://github.com/tehmoth/barnowl fix-jabber

Or you can view, comment on it, or merge it online at:

  https://github.com/barnowl/barnowl/pull/149

-- Commit Summary --

  * change BarnOwl::Module::Jabber::getServerFromJID to use Net::DNS::RR::SRV methods instead of hash elements (which seem to no longer work).  This unbreaks connecting via jabber to google or facebook

-- File Changes --

    M perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm (2)

-- Patch Links --

https://github.com/barnowl/barnowl/pull/149.patch
https://github.com/barnowl/barnowl/pull/149.diff

----==_mimepart_523909a8a9972_13b3103bd3474431
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>Fix BarnOwl::Module::Jabber::getServerFromJID to use Net::DNS::RR::SRV methods instead of hash access (which seem to no longer work).  This unbreaks connecting via Jabber to Google or Facebook.</p>

<hr>

<h4>You can merge this Pull Request by running</h4>
<pre>  git pull https://github.com/tehmoth/barnowl fix-jabber</pre>
<p>Or view, comment on, or merge it at:</p>
<p>&nbsp;&nbsp;<a href='https://github.com/barnowl/barnowl/pull/149'>https://github.com/barnowl/barnowl/pull/149</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>change BarnOwl::Module::Jabber::getServerFromJID to use Net::DNS::RR::SRV methods instead of hash elements (which seem to no longer work).  This unbreaks connecting via jabber to google or facebook</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/barnowl/barnowl/pull/149/files#diff-0">perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/barnowl/barnowl/pull/149.patch'>https://github.com/barnowl/barnowl/pull/149.patch</a></li>
  <li><a href='https://github.com/barnowl/barnowl/pull/149.diff'>https://github.com/barnowl/barnowl/pull/149.diff</a></li>
</ul>

----==_mimepart_523909a8a9972_13b3103bd3474431--

home help back first fref pref prev next nref lref last post