[356] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[D-O-H] r498 - trunk/owl

daemon@ATHENA.MIT.EDU (asedeno@MIT.EDU)
Thu Oct 29 18:05:16 2009

Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
To: dirty-owl-hackers@mit.edu
From: asedeno@MIT.EDU
Reply-to: dirty-owl-hackers@MIT.EDU
Date: Mon,  8 Jan 2007 19:39:24 -0500 (EST)

Author: asedeno
Date: 2007-01-08 19:39:23 -0500 (Mon, 08 Jan 2007)
New Revision: 498

Modified:
   trunk/owl/perlwrap.pm
Log:
Ripping out the thread support from perlwrap.pm, since we don't need
it and perl threads suck.



Modified: trunk/owl/perlwrap.pm
===================================================================
--- trunk/owl/perlwrap.pm	2007-01-08 23:50:12 UTC (rev 497)
+++ trunk/owl/perlwrap.pm	2007-01-09 00:39:23 UTC (rev 498)
@@ -289,19 +289,12 @@
 our @onGetBuddyList = ();
 
 ################################################################################
-# Mainloop hook and threading.
+# Mainloop hook
 ################################################################################
 
-use threads;
-use threads::shared;
-
-# Shared thread shutdown flag.
-# Consider adding a reload flag, so threads that should persist across reloads
-# can distinguish the two events. We wouldn't want a reload to cause us to
-# log out of and in to a perl-based IM session.
-our $shutdown : shared;
+our $shutdown;
 $shutdown = 0;
-our $reload : shared;
+our $reload;
 $reload = 0;
 
 # Functions to call hook lists
@@ -339,8 +332,7 @@
 # Modern versions of owl provides a great place to have shutdown stuff.
 # Put things in ~/.owl/shutdown
 
-# At this point I use owl::shutdown to tell any auxillary threads that they
-# should terminate.
+    # use $shutdown to tell modules that that's what we're doing.
     $shutdown = 1;
     mainloop_hook();
 }
@@ -361,23 +353,21 @@
 ################################################################################
 # Reload Code, taken from /afs/sipb/user/jdaniel/project/owl/perl
 ################################################################################
-sub reload_hook (@) 
+sub reload_hook (@)
 {
-    
-
     onStart();
     return 1;
 }
 
-sub reload 
+sub reload
 {
-    # Shutdown existing threads.
+    # Use $reload to tell modules that we're performing a reload.
     $reload = 1;
     owl::mainloop_hook();
     $reload = 0;
     @onMainLoop = ();
     @onStartSubs = ();
-    
+
     # Do reload
     package main;
     if (do "$ENV{HOME}/.owlconf" && owl::reload_hook(@_))


home help back first fref pref prev next nref lref last post