[3542] in BarnOwl Developers
Re: [barnowl] IRC reconnect (#108)
daemon@ATHENA.MIT.EDU (Edward Z. Yang)
Thu Aug 8 15:39:28 2013
Date: Thu, 08 Aug 2013 12:38:14 -0700
From: "Edward Z. Yang" <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-9709132-2001beb80c08e30b034e487c72b5d6a5a38438fb-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/108@github.com>
----==_mimepart_5203f3a64a299_d5511dfd48288a2
Date: Thu, 08 Aug 2013 12:38:14 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <5203f3a64cb18_d5511dfd4828959@worker6.rs.github.com.mail>
> Do you think we actually want to be noisy about duplicated joins?
No, I don't think it should be noisy. But the comment should be right.
> How about s/Use the -t flag./As per RFC 2812, spaces in channel names are illegal. If you really want to proceed anyway, use the -t flag./?
I mean, honestly, the validation should be done earlier.
> I guess I should go see what we do with .zephyr.subs
I think the key difference is that .zephyr.subs always consults the file, whereas your current implementation will short-circuit checking the file under some circumstances. But check it out.
---
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/108#issuecomment-22349605
----==_mimepart_5203f3a64a299_d5511dfd48288a2
Date: Thu, 08 Aug 2013 12:38:14 -0700
Mime-Version: 1.0
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <5203f3a64d93a_d5511dfd48290f3@worker6.rs.github.com.mail>
<blockquote>
<p>Do you think we actually want to be noisy about duplicated joins? </p>
</blockquote>
<p>No, I don't think it should be noisy. But the comment should be right.</p>
<blockquote>
<p>How about s/Use the -t flag./As per RFC 2812, spaces in channel names are illegal. If you really want to proceed anyway, use the -t flag./?</p>
</blockquote>
<p>I mean, honestly, the validation should be done earlier.</p>
<blockquote>
<p>I guess I should go see what we do with .zephyr.subs</p>
</blockquote>
<p>I think the key difference is that .zephyr.subs always consults the file, whereas your current implementation will short-circuit checking the file under some circumstances. But check it out.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href='https://github.com/barnowl/barnowl/pull/108#issuecomment-22349605'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/JJk3yKd0u6qAmPAmJXdf9_gRuUTQCipO-dP0x97pmbFICXxk9_eKsAFlYwLIF2Vi.gif' height='1' width='1'></p>
----==_mimepart_5203f3a64a299_d5511dfd48288a2--
