[3482] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 2497f9: Add tests to detect new_variable_*

daemon@ATHENA.MIT.EDU (GitHub)
Fri Jun 14 19:42:31 2013

Date: Fri, 14 Jun 2013 16:42:29 -0700
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu

----==_mimepart_51bbaa64f265d_5e5f1355de41195e2
Date: Fri, 14 Jun 2013 16:42:29 -0700
Mime-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51bbaa653134_5e5f1355de41196c3@hookshot-fe1-pe1-prd.aws.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/barnowl/barnowl
  Commit: 2497f994808dcb8c8c7f3098679a32d848c4bb87
      https://github.com/barnowl/barnowl/commit/2497f994808dcb8c8c7f3098679a32d848c4bb87
  Author: Robert Jacobs <rnjacobs@mit.edu>
  Date:   2013-06-14 (Fri, 14 Jun 2013)

  Changed paths:
    M t/variable.t

  Log Message:
  -----------
  Add tests to detect new_variable_* overriding previously set values

[davidben@mit.edu: Fix some nits]


  Commit: 5d8c9a71425710023c8cebb1d61f1d9b831b61b2
      https://github.com/barnowl/barnowl/commit/5d8c9a71425710023c8cebb1d61f1d9b831b61b2
  Author: David Benjamin <davidben@mit.edu>
  Date:   2013-06-14 (Fri, 14 Jun 2013)

  Changed paths:
    M t/variable.t

  Log Message:
  -----------
  Make the fullvar variable test more reasonable

Calling set on the output of get really should a no-op. Also test that
the new version of the setters were installed.


  Commit: f20daff712c5cbad4f7e6f763095a2b35770b35a
      https://github.com/barnowl/barnowl/commit/f20daff712c5cbad4f7e6f763095a2b35770b35a
  Author: David Benjamin <davidben@mit.edu>
  Date:   2013-06-14 (Fri, 14 Jun 2013)

  Changed paths:
    M variable.c

  Log Message:
  -----------
  Don't g_value_unset an uninitialized GValue

Silences a GObject assertion.


  Commit: 9d4dfdcd2d49dbcc22eb7c50544376042b61a6ba
      https://github.com/barnowl/barnowl/commit/9d4dfdcd2d49dbcc22eb7c50544376042b61a6ba
  Author: David Benjamin <davidben@mit.edu>
  Date:   2013-06-14 (Fri, 14 Jun 2013)

  Changed paths:
    M variable.c

  Log Message:
  -----------
  When replacing a variable, keep the old value

This unbreaks variable behavior on module reload.

Reported-By: Robert Jacobs <rnjacobs@mit.edu>


Compare: https://github.com/barnowl/barnowl/compare/80c0fc7442db...9d4dfdcd2d49

----==_mimepart_51bbaa64f265d_5e5f1355de41195e2--

home help back first fref pref prev next nref lref last post