[3466] in BarnOwl Developers
Re: [barnowl] Restore variable behavior on module reload (#139)
daemon@ATHENA.MIT.EDU (Jason Gross)
Sun Jun 9 12:20:14 2013
Date: Sun, 09 Jun 2013 09:20:11 -0700
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-15147578-52e8413f2fb9ccf06b2227a17fafd845a596f0b4-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/139@github.com>
----==_mimepart_51b4ab3bcd42d_7418134fde0899de
Date: Sun, 09 Jun 2013 09:20:11 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51b4ab3bd002d_7418134fde09004e@worker6.rs.github.com.mail>
A few (non-blocking) nits with @rnjacobs commit, to fix if you care about them.
The `die ...` and `$value = ` lines use tabs, the rest use spaces. (If you care about tabs vs spaces, I'd suggest spaces for everything here.)
The make check error messages aren't consistent; int and bool say "reinit shouldn't override", while the others say "reinit overrode".
But if you don't care about either/both of these, feel free to leave them as-is. Anyway, LGTM.
---
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/139#issuecomment-19168813
----==_mimepart_51b4ab3bcd42d_7418134fde0899de
Date: Sun, 09 Jun 2013 09:20:11 -0700
Mime-Version: 1.0
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51b4ab3bd0f6a_7418134fde09018a@worker6.rs.github.com.mail>
<p>A few (non-blocking) nits with <a href="https://github.com/rnjacobs" class="user-mention">@rnjacobs</a> commit, to fix if you care about them.<br>
The <code>die ...</code> and <code>$value =</code> lines use tabs, the rest use spaces. (If you care about tabs vs spaces, I'd suggest spaces for everything here.)<br>
The make check error messages aren't consistent; int and bool say "reinit shouldn't override", while the others say "reinit overrode".</p>
<p>But if you don't care about either/both of these, feel free to leave them as-is. Anyway, LGTM.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href='https://github.com/barnowl/barnowl/pull/139#issuecomment-19168813'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/JJk3yKd0u6qAmPAmJXdf95Do5FzIzccahfV6BmsAnyjQ7veGKBHJIlzV7taqei4Q.gif' height='1' width='1'></p>
----==_mimepart_51b4ab3bcd42d_7418134fde0899de--
