[3447] in BarnOwl Developers

home	help	back	first	fref	pref	prev	next	nref	lref	last	post

Re: [barnowl] IRC reconnect (#108)

daemon@ATHENA.MIT.EDU (Jason Gross)
Mon May 27 16:18:27 2013

Date: Mon, 27 May 2013 13:17:40 -0700
From: Jason Gross <notifications@github.com>
Reply-To: barnowl/barnowl <reply+i-9709132-2001beb80c08e30b034e487c72b5d6a5a38438fb-4475081@reply.github.com>
To: barnowl/barnowl <barnowl@noreply.github.com>
In-Reply-To: <barnowl/barnowl/pull/108@github.com>



----==_mimepart_51a3bf64a70e2_26bbc7fde4739e1
Date: Mon, 27 May 2013 13:17:40 -0700
Mime-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51a3bf64aaa82_26bbc7fde47404f@worker4.rs.github.com.mail>

I've updated the pull request:

- I've fixed the `open` syntax, and also now explicitly say `<:encoding(UTF-8)`.  I'm having trouble parsing http://perldoc.perl.org/perluniintro.html well enough to know what the default encoding is
- I've removed both uses of `//`
- I've reimplemented the file I/O in the IRC module in perl, rather than adding C bindings

---
Reply to this email directly or view it on GitHub:
https://github.com/barnowl/barnowl/pull/108#issuecomment-18513257

----==_mimepart_51a3bf64a70e2_26bbc7fde4739e1
Date: Mon, 27 May 2013 13:17:40 -0700
Mime-Version: 1.0
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <51a3bf64abbf5_26bbc7fde47419b@worker4.rs.github.com.mail>

<p>I've updated the pull request:</p>

<ul>
<li>I've fixed the <code>open</code> syntax, and also now explicitly say <code>&lt;:encoding(UTF-8)</code>.  I'm having trouble parsing <a href="http://perldoc.perl.org/perluniintro.html">http://perldoc.perl.org/perluniintro.html</a> well enough to know what the default encoding is</li>
<li>I've removed both uses of <code>//</code>
</li>
<li>I've reimplemented the file I/O in the IRC module in perl, rather than adding C bindings</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href='https://github.com/barnowl/barnowl/pull/108#issuecomment-18513257'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/JJk3yKd0u6qAmPAmJXdf9_gRuUTQCipO-dP0x97pmbFICXxk9_eKsAFlYwLIF2Vi.gif' height='1' width='1'></p>

----==_mimepart_51a3bf64a70e2_26bbc7fde4739e1--

home	help	back	first	fref	pref	prev	next	nref	lref	last	post