[3435] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

Re: tagging barnowl 1.9rc2 (= 1.9???) later today

daemon@ATHENA.MIT.EDU (Jason Gross)
Sun May 26 14:34:43 2013

In-Reply-To: <FF8151FA-D92E-4F0D-BF8C-C5ECB3C06D0C@mit.edu>
From: Jason Gross <jasongross9@gmail.com>
Date: Sun, 26 May 2013 14:34:10 -0400
To: Geoffrey Thomas <geofft@mit.edu>
Cc: Alex Dehnert <alex@dehnerts.com>, Geoffrey Thomas <geofft@ldpreload.com>,
        "barnowl-dev@mit.edu" <barnowl-dev@mit.edu>

--047d7b3a843af8310404dda3489a
Content-Type: text/plain; charset=ISO-8859-1

I have a number of patches which are just waiting for code review, some of
which I'd very much like to get acked and merged before 1.10. In
particular, I would like to get my *irc-rejoin* branch (
https://github.com/barnowl/barnowl/pull/108) merged; I have been using this
branch successfully for the past few months, and had no problems.  (I think
the only potential problem is that there's currently error message spew at
startup.  I can fix this, but only at the cost of silencing
duplicate-irc-subscription warnings.)

Here is a list of my other branches which I would like to get merged,
though not necessarily before 1.10:
*personal-consistency* (https://github.com/barnowl/barnowl/pull/117) -
ready for code review - perl and C disagree on what it means for a message
to be personal.  This branch fixes that.
*deferred-logging* (https://github.com/barnowl/barnowl/pull/109) - ready
for code review (but not yet extensively tested) - we currently drop logs
of messages that fail to be logged due to file errors.  This branch defers
such messages instead, and waits for the user to run :flush-logs to resume
logging.
*idle/away hooks in perl* (https://github.com/barnowl/barnowl/pull/49) -
ready for code review, in particular of my refactoring of calling perl in C
-- This is the first chunk of my branch that reimplements AIM support in
perl; that branch is nearly ready for code-review, but still has some
finishing touches (such as implementing the equivalent of irc-rejoin) and
testing left.
*perl-logging* (https://github.com/barnowl/barnowl/pull/54) - ready for
code review -- This large branch moves most of logging to perl.  This has
the benefit of (hopefully) cleaner code and better support for logging
non-zephyr messages (e.g., facebook, irc, jabber, aim, etc.).  There are
still a few significant decisions left to be made, which are noted in the
pull request description, and for which I'm looking for input.

(Eventually, I'll finish up my perl-aim branch, and submit a pull request
for that.  I might wait until some of these branches get merged, so that I
can just work on perl-aim on top of master.)

-Jason



On Sun, May 26, 2013 at 5:38 AM, Geoffrey Thomas <geofft@mit.edu> wrote:

> I was vaguely hoping to have the df locker by now, but yes, my intention
> is to add that onto the release branch when we get it. If it's important to
> add "Config error" before releasing barnowl-beta, I'm happy to do this in
> two commits,
>
> I'm not as familiar with the work on master and it looks like there might
> be unfinished stuff, so I don't have strong opinions on when to tag 1.10.
> Skipping the 1.9 release did vaguely occur to me, though.
>
> --
> Geoffrey Thomas (via mobile)
>
> On May 25, 2013, at 23:16, Alex Dehnert <alex@dehnerts.com> wrote:
>
> > Can we add the "default_format with a more useful error message" patch
> > (so "Config error: see http://web.mit.edu/df" or some such, instead of
> > just the URL)? It does seem like several people have received the new
> > default format and been confused.
> >
> > Also, is it worth planning to tag 1.10rc1 shortly after 1.9 releases? It
> > seems like we've gotten quite a few new commits between 1.9rc1 and now,
> > so maybe it's reasonable to do two releases in short order.
> >
> > ~~Alex
> >
> > On 05/25/2013 03:50 PM, Geoffrey Thomas wrote:
> >> I intend to tag barnowl 1.9rc2 with the contents of the release-1.9
> >> branch on my github clone:
> >>
> >> https://github.com/geofft/barnowl/commits/release-1.9
> >>
> >> This is barnowl 1.9rc1, plus a couple of serious-looking bugs from
> >> master that looked worth including in a release. My plan is to tag it
> >> either later today or tomorrow, do a locker build of barnowl-beta, and
> >> then do a release maybe a week later if all looks well.
> >>
> >> Let me know if there's anything that should get in the release that
> >> isn't there, or vice versa.
> >>
> >
>

--047d7b3a843af8310404dda3489a
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I have a number of patches which are just waiting for code=
 review, some of which I&#39;d very much like to get acked and merged befor=
e 1.10. In particular, I would like to get my <b>irc-rejoin</b> branch (<a =
href=3D"https://github.com/barnowl/barnowl/pull/108" target=3D"_blank">http=
s://github.com/barnowl/barnowl/pull/108</a>) merged; I have been using this=
 branch successfully for the past few months, and had no problems. =A0(I th=
ink the only potential problem is that there&#39;s currently error message =
spew at startup. =A0I can fix this, but only at the cost of silencing dupli=
cate-irc-subscription warnings.)<div>



<br></div><div>Here is a list of my other branches which I would like to ge=
t merged, though not necessarily before 1.10:</div><div><b>personal-consist=
ency</b> (<a href=3D"https://github.com/barnowl/barnowl/pull/117" target=3D=
"_blank">https://github.com/barnowl/barnowl/pull/117</a>) - ready for code =
review - perl and C disagree on what it means for a message to be personal.=
 =A0This branch fixes that.<br>



</div><div><b>deferred-logging</b> (<a href=3D"https://github.com/barnowl/b=
arnowl/pull/109" target=3D"_blank">https://github.com/barnowl/barnowl/pull/=
109</a>) - ready for code review (but not yet extensively tested) - we curr=
ently drop logs of messages that fail to be logged due to file errors. =A0T=
his branch defers such messages instead, and waits for the user to run :flu=
sh-logs to resume logging.</div>



<div><b>idle/away hooks in perl</b>=A0(<a href=3D"https://github.com/barnow=
l/barnowl/pull/49" target=3D"_blank">https://github.com/barnowl/barnowl/pul=
l/49</a>) - ready for code review, in particular of my refactoring of calli=
ng perl in C -- This is the first chunk of my branch that reimplements AIM =
support in perl; that branch is nearly ready for code-review, but still has=
 some finishing touches (such as implementing the equivalent of irc-rejoin)=
 and testing left.</div>



<div><b>perl-logging</b>=A0(<a href=3D"https://github.com/barnowl/barnowl/p=
ull/54" target=3D"_blank">https://github.com/barnowl/barnowl/pull/54</a>) -=
 ready for code review -- This large branch moves most of logging to perl. =
=A0This has the benefit of (hopefully) cleaner code and better support for =
logging non-zephyr messages (e.g., facebook, irc, jabber, aim, etc.). =A0Th=
ere are still a few significant decisions left to be made, which are noted =
in the pull request description, and for which I&#39;m looking for input.</=
div>

<div><br></div><div style>(Eventually, I&#39;ll finish up my perl-aim branc=
h, and submit a pull request for that. =A0I might wait until some of these =
branches get merged, so that I can just work on perl-aim on top of master.)=
</div>

<div><br></div><div style>-Jason</div><div><br></div></div><div class=3D"gm=
ail_extra"><br><br><div class=3D"gmail_quote">On Sun, May 26, 2013 at 5:38 =
AM, Geoffrey Thomas <span dir=3D"ltr">&lt;<a href=3D"mailto:geofft@mit.edu"=
 target=3D"_blank">geofft@mit.edu</a>&gt;</span> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">I was vaguely hoping to have the df locker b=
y now, but yes, my intention is to add that onto the release branch when we=
 get it. If it&#39;s important to add &quot;Config error&quot; before relea=
sing barnowl-beta, I&#39;m happy to do this in two commits,<br>


<br>
I&#39;m not as familiar with the work on master and it looks like there mig=
ht be unfinished stuff, so I don&#39;t have strong opinions on when to tag =
1.10. Skipping the 1.9 release did vaguely occur to me, though.<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
--<br>
Geoffrey Thomas (via mobile)<br>
</font></span><div class=3D"HOEnZb"><div class=3D"h5"><br>
On May 25, 2013, at 23:16, Alex Dehnert &lt;<a href=3D"mailto:alex@dehnerts=
.com">alex@dehnerts.com</a>&gt; wrote:<br>
<br>
&gt; Can we add the &quot;default_format with a more useful error message&q=
uot; patch<br>
&gt; (so &quot;Config error: see <a href=3D"http://web.mit.edu/df" target=
=3D"_blank">http://web.mit.edu/df</a>&quot; or some such, instead of<br>
&gt; just the URL)? It does seem like several people have received the new<=
br>
&gt; default format and been confused.<br>
&gt;<br>
&gt; Also, is it worth planning to tag 1.10rc1 shortly after 1.9 releases? =
It<br>
&gt; seems like we&#39;ve gotten quite a few new commits between 1.9rc1 and=
 now,<br>
&gt; so maybe it&#39;s reasonable to do two releases in short order.<br>
&gt;<br>
&gt; ~~Alex<br>
&gt;<br>
&gt; On 05/25/2013 03:50 PM, Geoffrey Thomas wrote:<br>
&gt;&gt; I intend to tag barnowl 1.9rc2 with the contents of the release-1.=
9<br>
&gt;&gt; branch on my github clone:<br>
&gt;&gt;<br>
&gt;&gt; <a href=3D"https://github.com/geofft/barnowl/commits/release-1.9" =
target=3D"_blank">https://github.com/geofft/barnowl/commits/release-1.9</a>=
<br>
&gt;&gt;<br>
&gt;&gt; This is barnowl 1.9rc1, plus a couple of serious-looking bugs from=
<br>
&gt;&gt; master that looked worth including in a release. My plan is to tag=
 it<br>
&gt;&gt; either later today or tomorrow, do a locker build of barnowl-beta,=
 and<br>
&gt;&gt; then do a release maybe a week later if all looks well.<br>
&gt;&gt;<br>
&gt;&gt; Let me know if there&#39;s anything that should get in the release=
 that<br>
&gt;&gt; isn&#39;t there, or vice versa.<br>
&gt;&gt;<br>
&gt;<br>
</div></div></blockquote></div><br></div>

--047d7b3a843af8310404dda3489a--

home help back first fref pref prev next nref lref last post