[3418] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 731e92: Make check for non-existant channel more

daemon@ATHENA.MIT.EDU (GitHub)
Mon May 20 12:19:19 2013

Date: Mon, 20 May 2013 09:19:15 -0700
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu

----==_mimepart_519a4d03d9881_384b134bde441521
Date: Mon, 20 May 2013 09:19:15 -0700
Mime-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <519a4d03e2d8a_384b134bde4416ae@hookshot-fe1-pe1-prd.aws.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/barnowl/barnowl
  Commit: 731e921fabe20fb70a9578e3237ec87804111276
      https://github.com/barnowl/barnowl/commit/731e921fabe20fb70a9578e3237ec87804111276
  Author: Jason Gross <jgross@mit.edu>
  Date:   2013-05-20 (Mon, 20 May 2013)

  Changed paths:
    M perl/modules/IRC/lib/BarnOwl/Module/IRC.pm

  Log Message:
  -----------
  Make check for non-existant channel more correct

Currently, this doesn't change anything; all channels start with '#'.
However, when pull #107 (Improve irc-msg support for multiple
connections) lands we want to accept, e.g., '0' as a valid user name.
So we should actually be checking if the value is defined, rather than
if it's not falsy.  Perhaps we should also exclude empty strings,
spaces, etc., as valid user names/channels.




----==_mimepart_519a4d03d9881_384b134bde441521--

home help back first fref pref prev next nref lref last post