[3388] in BarnOwl Developers
[barnowl/barnowl] 60e861: Don't swallow errors in :unsuball
daemon@ATHENA.MIT.EDU (GitHub)
Thu Apr 18 15:20:15 2013
Date: Thu, 18 Apr 2013 12:20:11 -0700
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu
----==_mimepart_5170476b6ad14_79ac821e1417725
Date: Thu, 18 Apr 2013 12:20:11 -0700
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <5170476b6ce67_79ac821e1417842@hookshot-fe5-pe1-prd.aws.github.net.mail>
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 60e8617904bd9d4cfd97f15d5ec92e713962db99
https://github.com/barnowl/barnowl/commit/60e8617904bd9d4cfd97f15d5ec92e713962db99
Author: David Benjamin <davidben@mit.edu>
Date: 2013-04-05 (Fri, 05 Apr 2013)
Changed paths:
M functions.c
M zephyr.c
Log Message:
-----------
Don't swallow errors in :unsuball
More code that should get fixed if we ever use GError or some other saner error
reporting mechanism. For now, I suppose this mess with the lower-level function
reporting error and the higher-level function reporting success is in good
company.
Test by doing a kdestroy before :unsuball. It should complain about a SERVNAK.
(It really should complain about missing credentials cache, but apparently
libzephyr tries again without auth in ZCancelSubscription even though the
server rejects unauthenticated ones. Meh.)
----==_mimepart_5170476b6ad14_79ac821e1417725--
