[3355] in BarnOwl Developers
[barnowl/barnowl] 06e04a: perlvariables - iteration N
daemon@ATHENA.MIT.EDU (GitHub)
Sun Feb 24 18:01:42 2013
Date: Sun, 24 Feb 2013 15:01:39 -0800
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu
----==_mimepart_512a9bd3a8c1b_2ef71a50af499068
Date: Sun, 24 Feb 2013 15:01:39 -0800
Mime-Version: 1.0
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <512a9bd3abff4_2ef71a50af49912d@sh2.rs.github.com.mail>
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 06e04a995f32e4c88df08bff7baf37fb5bc8a59c
https://github.com/barnowl/barnowl/commit/06e04a995f32e4c88df08bff7baf37fb5bc8a59c
Author: Adam Glasgall <adam@crossproduct.net>
Date: 2013-02-19 (Tue, 19 Feb 2013)
Changed paths:
M Makefile.am
A closures.c
M configure.ac
A gmarshal_funcs.c
A gmarshal_funcs.h
A marshal_types
M owl.c
M owl.h
M perlconfig.c
M perlglue.xs
M variable.c
Log Message:
-----------
perlvariables - iteration N
Later commits reworked a lot of this, but the use of GValue over void*
was kept.
Commit: 353719a2ddec4d6a8458ee42af37514fedbd80bf
https://github.com/barnowl/barnowl/commit/353719a2ddec4d6a8458ee42af37514fedbd80bf
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-19 (Tue, 19 Feb 2013)
Changed paths:
M Makefile.am
M commands.c
R gmarshal_funcs.c
R gmarshal_funcs.h
M marshal_types
M owl.h
M perlconfig.c
M perlglue.xs
M tester.c
M variable.c
Log Message:
-----------
Start of perlvariables iteration N+1
New plan: the C <-> perl interface deals entirely with strings. Storage
is entirely perl-side. C does not know and doesn't care about the
underlying perl-side types. Note that this means an "int" variable in C
land and an "int" variable in perl land have no relation.
Commit: 5001a3df5a2fd9b81667817e486556661f9e6ead
https://github.com/barnowl/barnowl/commit/5001a3df5a2fd9b81667817e486556661f9e6ead
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-19 (Tue, 19 Feb 2013)
Changed paths:
M owl.h
M variable.c
Log Message:
-----------
g_strdup validsettings
This'll allow perl to set it too.
Commit: 897fc1c486d9bf7768908eb79030e9f7829b51f3
https://github.com/barnowl/barnowl/commit/897fc1c486d9bf7768908eb79030e9f7829b51f3
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-19 (Tue, 19 Feb 2013)
Changed paths:
M variable.c
Log Message:
-----------
Fix error messages a bit
Commit: e5210c98551ad1835a4e926515106b3e2f04eab8
https://github.com/barnowl/barnowl/commit/e5210c98551ad1835a4e926515106b3e2f04eab8
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-19 (Tue, 19 Feb 2013)
Changed paths:
M owl.c
M perlconfig.c
Log Message:
-----------
dlsym the functions we need after use Glib and before use BarnOwl
After use Glib so the library is loaded. Before use BarnOwl so we try to
use them before they're available.
Commit: 69f74c224f994c1b7eb73c43474e4e31a6dc5854
https://github.com/barnowl/barnowl/commit/69f74c224f994c1b7eb73c43474e4e31a6dc5854
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-19 (Tue, 19 Feb 2013)
Changed paths:
M owl.h
M perl/lib/BarnOwl.pm
M perlglue.xs
M variable.c
Log Message:
-----------
And now... the moment you've all been waiting for...
Expose OWL_VARIABLE_OTHER variables to perl. Rewrite all perl variable
entry points to use that one. From now on, C only thinks of these
variables as strings.
(This has one regression to be fixed in a later commit: you can't
set/unset with no arguments since we don't know how to set from
boolean.)
Commit: 3b9ca713910ca1c21db2aa8293da541e66eaa97c
https://github.com/barnowl/barnowl/commit/3b9ca713910ca1c21db2aa8293da541e66eaa97c
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-19 (Tue, 19 Feb 2013)
Changed paths:
M commands.c
M owl.h
M perl/lib/BarnOwl.pm
M perlglue.xs
M variable.c
Log Message:
-----------
Allow perl variables to participate in argumentless set/unset
Commit: 4584d1f2ed67b7d2da9e830ef2a983cca8f17f4c
https://github.com/barnowl/barnowl/commit/4584d1f2ed67b7d2da9e830ef2a983cca8f17f4c
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-21 (Thu, 21 Feb 2013)
Changed paths:
M owl.h
M variable.c
Log Message:
-----------
Pipe all C-created variables through function calls
Gets us some long-overdue type checking in the various type-specific
callbacks.
Commit: 1a4508bcbaec4bad0086dba0ea62279aa6fb6a7c
https://github.com/barnowl/barnowl/commit/1a4508bcbaec4bad0086dba0ea62279aa6fb6a7c
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-21 (Thu, 21 Feb 2013)
Changed paths:
M tester.c
Log Message:
-----------
Fix the unit tests
The arguments got reordered slightly to match the nasty macros.
Commit: f41956dfc4f78891b98933151e7262f3ce9b408f
https://github.com/barnowl/barnowl/commit/f41956dfc4f78891b98933151e7262f3ce9b408f
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-21 (Thu, 21 Feb 2013)
Changed paths:
M variable.c
Log Message:
-----------
Merge owl_variable_free and owl_variable_cleanup
We don't do the init/cleanup thing anymore.
Commit: 63d3e4eecc87289cc9371abfe57a4417c32b1607
https://github.com/barnowl/barnowl/commit/63d3e4eecc87289cc9371abfe57a4417c32b1607
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-21 (Thu, 21 Feb 2013)
Changed paths:
M variable.c
Log Message:
-----------
Make GClosure invokes more mechanical
We don't really need some of those g_value_unsets, but we may as well
avoid making assumptions. Someone else might copy-and-paste the code
later and get it wrong.
Commit: 523146b73112d93e02bd354f409631c03290d526
https://github.com/barnowl/barnowl/commit/523146b73112d93e02bd354f409631c03290d526
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-23 (Sat, 23 Feb 2013)
Changed paths:
M perl/lib/BarnOwl.pm
Log Message:
-----------
Add new_variable_full
Route everything through that.
Commit: e26abb6dcabbc2af2f69280f1b4ea0175e72ad4e
https://github.com/barnowl/barnowl/commit/e26abb6dcabbc2af2f69280f1b4ea0175e72ad4e
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-23 (Sat, 23 Feb 2013)
Changed paths:
M perl/lib/BarnOwl.pm
Log Message:
-----------
Add new_variable_enum
This seems to work. Yay.
Commit: bbc31e47b279ccc502d0452ffed590280f0527d6
https://github.com/barnowl/barnowl/commit/bbc31e47b279ccc502d0452ffed590280f0527d6
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-23 (Sat, 23 Feb 2013)
Changed paths:
M owl.h
Log Message:
-----------
Whitespace that I don't feel like rebasing
Sigh. Tabs and spaces.
Commit: 366badc0c70327da4a796c4db041cf1941dbe996
https://github.com/barnowl/barnowl/commit/366badc0c70327da4a796c4db041cf1941dbe996
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-23 (Sat, 23 Feb 2013)
Changed paths:
M tester.c
Log Message:
-----------
Add some unit tests for enum variables
So we don't break them again.
Commit: f0a7c09aac1aae61a8bcadbcfd9d053015b8afc1
https://github.com/barnowl/barnowl/commit/f0a7c09aac1aae61a8bcadbcfd9d053015b8afc1
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-23 (Sat, 23 Feb 2013)
Changed paths:
M variable.c
Log Message:
-----------
Remove read-only variable check
Those are impossible now and were impossible before this branch (except
for the old "OWL_VARIABLE_OTHER" thing, which was unused). Yay deleting
code.
Commit: 4419d3dc0be4c5f16e1c0f6235a9e024206790c8
https://github.com/barnowl/barnowl/commit/4419d3dc0be4c5f16e1c0f6235a9e024206790c8
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-23 (Sat, 23 Feb 2013)
Changed paths:
A t/variable.t
Log Message:
-----------
Add unit tests for perl-side variables
Commit: 4953c44b539a53767c2742d4b17e5c477471d88c
https://github.com/barnowl/barnowl/commit/4953c44b539a53767c2742d4b17e5c477471d88c
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-23 (Sat, 23 Feb 2013)
Changed paths:
M perl/lib/BarnOwl.pm
M t/variable.t
Log Message:
-----------
Change set_fromstring to die on failure
Returning zero/non-zero is awkward. Leave a note for future improvement
to pass the error message along, although the default one is pretty
reasonable already.
Commit: 6a8b5190384f683113444387b65b59ef66bb779f
https://github.com/barnowl/barnowl/commit/6a8b5190384f683113444387b65b59ef66bb779f
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-23 (Sat, 23 Feb 2013)
Changed paths:
M tester.c
M variable.c
Log Message:
-----------
Remove pointless return code from owl_variable_add_defaults
Commit: 104a4eb952a68c48da10585deab68e021a648ca6
https://github.com/barnowl/barnowl/commit/104a4eb952a68c48da10585deab68e021a648ca6
Author: David Benjamin <davidben@mit.edu>
Date: 2013-02-23 (Sat, 23 Feb 2013)
Changed paths:
M perl/lib/BarnOwl.pm
Log Message:
-----------
Accept validsettings in new_variable_string
If people reeeaaally want to, I suppose they could pass in "<path>" or
something silly. Whatever.
Commit: a54ffe6839e5b62959015f1b05feb5d0ec74dcde
https://github.com/barnowl/barnowl/commit/a54ffe6839e5b62959015f1b05feb5d0ec74dcde
Author: Adam Glasgall <adam@crossproduct.net>
Date: 2013-02-24 (Sun, 24 Feb 2013)
Changed paths:
M Makefile.am
A closures.c
M commands.c
M configure.ac
A marshal_types
M owl.h
M perl/lib/BarnOwl.pm
M perlconfig.c
M perlglue.xs
A t/variable.t
M tester.c
M variable.c
Log Message:
-----------
Merge pull request #118 from davidben/perlvariables-n-plus-1
Merging perlvariables work, since all issues seem to have been addressed.
Compare: https://github.com/barnowl/barnowl/compare/bbe7d4a8ffa8...a54ffe6839e5
----==_mimepart_512a9bd3a8c1b_2ef71a50af499068--
