[3272] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 2354e9: If zcrypt fails to decrypt, strip away the

daemon@ATHENA.MIT.EDU (GitHub)
Thu May 10 01:46:28 2012

Date: Wed, 09 May 2012 22:46:26 -0700
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu



----==_mimepart_4fab56323e445_2d6816e3aec745f9
Date: Wed, 09 May 2012 22:46:26 -0700
Mime-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <4fab56323fa74_2d6816e3aec7463e@sh3.rs.github.com.mail>

  Branch: refs/heads/master
  Home:   https://github.com/barnowl/barnowl
  Commit: 2354e9a5fabd3efa2825b96557715caa33ede671
      https://github.com/barnowl/barnowl/commit/2354e9a5fabd3efa2825b96557715caa33ede671
  Author: David Benjamin <davidben@mit.edu>
  Date:   2012-05-09 (Wed, 09 May 2012)

  Changed paths:
    M message.c

  Log Message:
  -----------
  If zcrypt fails to decrypt, strip away the zcrypt opcode

Otherwise you can make a message look encrypted by sending it with a
faked 'crypt' opcode. It also confuses the reply command. Replace it
with 'failed-decrypt' just so it shows up in the UI somehow. Perhaps
someone can write perl code to retry zcrypt on all messages with that
opcode.

Also has the side effect of marking gibberish so the user has some hope
of realizing what happened if they sub to a zcrypted class without the
key.

And initialize out to NULL since there's actually a codepath where that
value never gets set.

Reported-by: Melissa Hunt <wings@mit.edu>




----==_mimepart_4fab56323e445_2d6816e3aec745f9--

home help back first fref pref prev next nref lref last post