[3242] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 389d48: Switch to interactive context before

daemon@ATHENA.MIT.EDU (GitHub)
Mon Jan 23 15:34:07 2012

Date: Mon, 23 Jan 2012 12:34:05 -0800
From: GitHub <noreply@github.com>
Reply-To: GitHub <noreply@github.com>
To: barnowl-dev@mit.edu



----==_mimepart_4f1dc43d9b227_4b673f81f6d7c2f83878ca
Date: Mon, 23 Jan 2012 12:34:05 -0800
Mime-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-ID: <4f1dc43d9e5f6_4b673f81f6d7c2f8387924@sh1.rs.github.com.mail>

  Branch: refs/heads/master
  Home:   https://github.com/barnowl/barnowl
  Commit: 389d48749c4eb68f218e9fd6faf953ba542bfb75
      https://github.com/barnowl/barnowl/commit/389d48749c4eb68f218e9fd6faf953ba542bfb75
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-10-17 (Mon, 17 Oct 2011)

  Changed paths:
    M owl.c

  Log Message:
  -----------
  Switch to interactive context before sourcing the startup file

There are no invariants that don't hold before the previous place we
flip the interactive bit; although default_style is applied afterwards,
there is still a style set before that code.

There is no code which reads the READCONFIG bit, so no behavior should
change from there. Setting the interactive bit makes
owl_function_load{login,}subs noisier, but that's fine. A number of
commands were labeled OWL_CTX_INTERACTIVE, but that doesn't change much
because, unless the command is OWLCMD_*_CTX, the bits are ignored.

What does change is that .owl/startup is allowed to leave with a context
on the stack. In particular, this /finally/ fixes #161.

More fundamentally, this makes .owl/startup identical to the user having
run those commands in succession, which is a nice simplification.




----==_mimepart_4f1dc43d9b227_4b673f81f6d7c2f83878ca--

home help back first fref pref prev next nref lref last post