[3220] in BarnOwl Developers
[barnowl/barnowl] d953ed: Rename owl_zwrite_new to owl_zwrite_new_from_line
daemon@ATHENA.MIT.EDU (noreply@github.com)
Fri Sep 30 23:20:36 2011
Date: Fri, 30 Sep 2011 20:20:33 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: d953ede767fb537e3eacf7d9962809191ec38c5c
https://github.com/barnowl/barnowl/commit/d953ede767fb537e3eacf7d9962809191ec38c5c
Author: David Benjamin <davidben@mit.edu>
Date: 2011-09-30 (Fri, 30 Sep 2011)
Changed paths:
M commands.c
M zephyr.c
M zwrite.c
Log Message:
-----------
Rename owl_zwrite_new to owl_zwrite_new_from_line
owl_zwrite_new will take an argv, like god intended.
Commit: 7b89e8cbe6bf87b1f2950e4c4a73c77645eb5363
https://github.com/barnowl/barnowl/commit/7b89e8cbe6bf87b1f2950e4c4a73c77645eb5363
Author: David Benjamin <davidben@mit.edu>
Date: 2011-09-30 (Fri, 30 Sep 2011)
Changed paths:
M util.c
Log Message:
-----------
Add owl_argv_quote convenience function
Did we really never write this thing?
Commit: 6329cd5136a27361dedf94bb92e20fa2d327e43c
https://github.com/barnowl/barnowl/commit/6329cd5136a27361dedf94bb92e20fa2d327e43c
Author: David Benjamin <davidben@mit.edu>
Date: 2011-09-30 (Fri, 30 Sep 2011)
Changed paths:
M zwrite.c
Log Message:
-----------
Allow building a zwrite from an argv
Add new versions of owl_zwrite_create and owl_zwrite_new. Note that this
means we rebuild z->zwriteline from scratch unconditionally. The only
behavior change is that the user's spacing and quoting is not preserved
in zwrite locktext. For instance
:zwrite davidben -i "spaces yay?"
now gets a locktext of
----> zwrite davidben -i 'spaces yay?'
I think this isn't a big deal. It already happens for every other *write
locktext, and if we kill the buff argument, it'll happen there too.
Commit: f89cc6fa54344f8f6b48601228af46e8fc95caea
https://github.com/barnowl/barnowl/commit/f89cc6fa54344f8f6b48601228af46e8fc95caea
Author: David Benjamin <davidben@mit.edu>
Date: 2011-09-30 (Fri, 30 Sep 2011)
Changed paths:
M commands.c
Log Message:
-----------
Use the pre-parsed argc/argv in building owl_zwrites
When called programmatically, the buff argument is, unfortunately,
bogus. Quoting that correctly is somewhat more of a pain due to
skiptokens commands. (See e3c8332fa85642544dba1222912b77cf6e32ce8c and
6a7111370ea0e1de2c3eb86a85f34cd68848d4b1. Though we really should fix
that properly sometime.) This fixes programmatically sending zwrites
from perl with spaces and such. For instance,
BarnOwl::zwrite('-c', 'barnowl', '-i', 'spaces yay?');
and
BarnOwl::zwrite('davidben', '-m', "mangoes\nare\ntasty");
It also, as a side effect, brings us one small step closer to
eliminating the buff argument from C commands.
Reported-by: Alex Dehnert <adehnert@mit.edu>
Compare: https://github.com/barnowl/barnowl/compare/7803326...f89cc6f
