[3169] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] f27112: Fix up headers

daemon@ATHENA.MIT.EDU (noreply@github.com)
Sun Jul 24 23:51:58 2011

Date: Sun, 24 Jul 2011 20:51:55 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com

  Branch: refs/heads/master
  Home:   https://github.com/barnowl/barnowl

  Commit: f271129fbb186598811b923e406d65f9d2b3031a
      https://github.com/barnowl/barnowl/commit/f271129fbb186598811b923e406d65f9d2b3031a
  Author: Jason Gross <jgross@mit.edu>
  Date:   2011-07-24 (Sun, 24 Jul 2011)

  Changed paths:
    M aim.c
  M cmd.c
  M commands.c
  M context.c
  M dict.c
  M editcontext.c
  M editwin.c
  M filter.c
  M filterproc.c
  M fmtext.c
  M functions.c
  M global.c
  M help.c
  M keybinding.c
  M keymap.c
  M keypress.c
  M logging.c
  M message.c
  M messagelist.c
  M owl.c
  M owl.h
  M owl_perl.h
  M perlconfig.c
  M perlglue.xs
  M regex.c
  M tester.c
  M text.c
  M util.c
  M variable.c
  M view.c
  M viewwin.c
  M window.c
  M zephyr.c
  M zwrite.c

  Log Message:
  -----------
  Fix up headers

The additions to owl.h and some of the removals were done by
Alejandro SedeƱo <asedeno@mit.edu> in commit
77a0258b3919468fc9d7f7602588ac427ab36e6c.

Notes:

* I think owl.c lost the need for sys/time.h when we punted select() in
  favor of glib's main loop.
* We don't actually need to include things like stdarg.h, stdio.h,
  glib/gstdio.h, glib-object.h.  I think they get indirectly included
  via owl.h and/or glib.h.  They're left in (or added in to) the files
  that use functions/types from them.
* I'm not entirely sure what sys/socket.h is doing in message.c.  It
  is there from the initial commit.  I suspect it might have had
  something to do with the call to getnameinfo.  message.c compiles
  without it, but
  http://pubs.opengroup.org/onlinepubs/009695399/functions/getnameinfo.html
  suggests that we're supposed to include it?  *shrugs*  I'm leaving it
  in, for now.  (Rather, I'll leave one copy of the #include in.)



home help back first fref pref prev next nref lref last post