[3158] in BarnOwl Developers
[barnowl/barnowl] 18fd56: Assign all watched signals to a dummy no-op dispos...
daemon@ATHENA.MIT.EDU (noreply@github.com)
Sat Jul 23 21:25:32 2011
Date: Sat, 23 Jul 2011 18:25:29 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/release-1.8
Home: https://github.com/barnowl/barnowl
Commit: 18fd568508baa364708f99d17ea74b0a5c12080e
https://github.com/barnowl/barnowl/commit/18fd568508baa364708f99d17ea74b0a5c12080e
Author: David Benjamin <davidben@mit.edu>
Date: 2011-07-23 (Sat, 23 Jul 2011)
Changed paths:
M owl.c
M signal.c
Log Message:
-----------
Assign all watched signals to a dummy no-op disposition
Otherwise some (namely SIGWINCH) may have SIG_DFL = SIG_IGN. This means
that the signal is ignored if the signal thread is in the middle of
processing another signal (a race condition), and on Solaris it's not
delivered at all.
Also more consistently consider errors in setup here fatal. And rename
CHECK_RESULT to OR_DIE.
Reported-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Adam Glasgall <adam@crossproduct.net>
