[3155] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] a7fac1: Assign all watched signals to a dummy no-op dispos...

daemon@ATHENA.MIT.EDU (noreply@github.com)
Sat Jul 23 19:32:45 2011

Date: Sat, 23 Jul 2011 16:32:43 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com

  Branch: refs/heads/master
  Home:   https://github.com/barnowl/barnowl

  Commit: a7fac140d17626bc37808cae6b389f3240135903
      https://github.com/barnowl/barnowl/commit/a7fac140d17626bc37808cae6b389f3240135903
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-23 (Sat, 23 Jul 2011)

  Changed paths:
    M owl.c
  M signal.c

  Log Message:
  -----------
  Assign all watched signals to a dummy no-op disposition

Otherwise some (namely SIGWINCH) may have SIG_DFL = SIG_IGN. This means
that the signal is ignored if the signal thread is in the middle of
processing another signal (a race condition), and on Solaris it's not
delivered at all.

Also more consistently consider errors in setup here fatal. And rename
CHECK_RESULT to OR_DIE.

Reported-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Adam Glasgall <adam@crossproduct.net>



home help back first fref pref prev next nref lref last post