[3153] in BarnOwl Developers
[barnowl/barnowl] 14be3a: Give owl_text_indent an indent_first_line paramete...
daemon@ATHENA.MIT.EDU (noreply@github.com)
Thu Jul 21 17:12:56 2011
Date: Thu, 21 Jul 2011 14:12:53 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 14be3a516baee0a39a99eada3fd50d39455b4724
https://github.com/barnowl/barnowl/commit/14be3a516baee0a39a99eada3fd50d39455b4724
Author: Jason Gross <jgross@mit.edu>
Date: 2011-07-21 (Thu, 21 Jul 2011)
Changed paths:
M cmd.c
M style.c
M text.c
Log Message:
-----------
Give owl_text_indent an indent_first_line parameter
This is useful if you need to indent text that isn't broken into chunks
that end with newlines.
This is primarily in preparation for the next commit, where we need to
replace the indent on the first line by a prefix. The other
(reasonable) option is to make owl_text_indent always prefix the string
it's given with an indent, even when it's given the empty string. This
would break the nice property that indent(A + B) = indent(A) + indent(B)
whenever A ended with a newline. After some discussion on zephyr and on
the github pull request, I decided to go with this option.
Commit: 6500907f6e410b9b8ffb57962f97795ebeb0ccd5
https://github.com/barnowl/barnowl/commit/6500907f6e410b9b8ffb57962f97795ebeb0ccd5
Author: Jason Gross <jgross@mit.edu>
Date: 2011-07-21 (Thu, 21 Jul 2011)
Changed paths:
M functions.c
M message.c
Log Message:
-----------
Correctly display multiline fields in :info
Commit 259e60a8abc2d2d41bc7a484b02a334fdd13857f removed the length limit
on :info, but kept the replacement of '\n' with '~' and '\r' with '!'.
This replacement came with the initial commit, with a comment of "/*
just for testing for now */". This commit does away with that
replacement, and indents the fields for display purposes.
This is particularly useful for messages that have very long fields,
such as the original xml field for jabber messages.
Trailing newlines (e.g., in formats or in the message body) are doubled,
because the code is simpler that way, and because I don't see a
compelling reason to strip them.
Compare: https://github.com/barnowl/barnowl/compare/d8f22b6...6500907
