[3148] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 650415: Pass initval to owl_variable_dict_newvar_bool as i...

daemon@ATHENA.MIT.EDU (noreply@github.com)
Tue Jul 19 02:26:49 2011

Date: Mon, 18 Jul 2011 23:26:48 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com

  Branch: refs/heads/release-1.8
  Home:   https://github.com/barnowl/barnowl

  Commit: 650415ef71777c3a7de45d31a735a8e3b383abe0
      https://github.com/barnowl/barnowl/commit/650415ef71777c3a7de45d31a735a8e3b383abe0
  Author: David Benjamin <davidben@mit.edu>
  Date:   2011-07-18 (Mon, 18 Jul 2011)

  Changed paths:
    M variable.c

  Log Message:
  -----------
  Pass initval to owl_variable_dict_newvar_bool as int, not bool

While bool is ostensibly cleaner, the rest of the code dealing with bool
owl_variables treats it as an int. Switching only this one results in
valgrind complaining about conditioning on uninitialized values because
we end up casting bool* to int*.



home help back first fref pref prev next nref lref last post