[3128] in BarnOwl Developers
[barnowl/barnowl] bc1d64: Drop require_type
daemon@ATHENA.MIT.EDU (noreply@github.com)
Sun Jul 3 21:11:58 2011
Date: Sun, 3 Jul 2011 18:11:50 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: bc1d64834a2b9c92b2d947386c6bc93921e3c037
https://github.com/barnowl/barnowl/commit/bc1d64834a2b9c92b2d947386c6bc93921e3c037
Author: Jason Gross <jgross@mit.edu>
Date: 2011-07-03 (Sun, 03 Jul 2011)
Changed paths:
M tester.c
M variable.c
Log Message:
-----------
Drop require_type
It's not doing much for us (and would do even less after the next
commit).
I'm not sure whether or not we should type-check owl_variable_get_*
Commit: ca54fd61683ca4456f68b3b3758e941cc6d93e24
https://github.com/barnowl/barnowl/commit/ca54fd61683ca4456f68b3b3758e941cc6d93e24
Author: Jason Gross <jgross@mit.edu>
Date: 2011-07-03 (Sun, 03 Jul 2011)
Changed paths:
M commands.c
M functions.c
M help.c
M stubgen.pl
M tester.c
M variable.c
Log Message:
-----------
Pass owl_variable * around instead of owl_vardict *.
This allows (forces) functions to do their own NULL- and type- checking
on variables. The functions in varsubs.c get less checking, but if
these auto-generated functions are failing, something more serious is
probably wrong.
The owl_variable_get_* functions type-check their arguments, and
owl_function_error if the argument is the wrong type (it's a programmer
error and we should make some noise).
Commit: ca749a95d6931025b7d334764a6776c9dbf0325d
https://github.com/barnowl/barnowl/commit/ca749a95d6931025b7d334764a6776c9dbf0325d
Author: Jason Gross <jgross@mit.edu>
Date: 2011-07-03 (Sun, 03 Jul 2011)
Changed paths:
M commands.c
M functions.c
M variable.c
Log Message:
-----------
Make variable getters return NULL instead of "<null>"
This fixes trac-#184:
Since commit 010a9511420887329269aa51e7598533e826c57f, the default zsigs
show up as empty; BarnOwl::default_zephyr_signature() checks
BarnOwl::getvar('zsigproc') as a boolean (which may be incorrect if you
happen to have a zsigproc called 0). As of that commit, BarnOwl::getvar
returns "<null>" instead of undef.
Commit: b4a678ada6187f20944178fb74b7c3694d8b73cf
https://github.com/barnowl/barnowl/commit/b4a678ada6187f20944178fb74b7c3694d8b73cf
Author: Jason Gross <jgross@mit.edu>
Date: 2011-07-03 (Sun, 03 Jul 2011)
Changed paths:
M tester.c
Log Message:
-----------
Added tests to tester.c to make sure that NULL values are gotten appropriately
Commit: 1dab38e70f0d014bb1ff3850e74dd2d048932646
https://github.com/barnowl/barnowl/commit/1dab38e70f0d014bb1ff3850e74dd2d048932646
Author: Jason Gross <jgross@mit.edu>
Date: 2011-07-03 (Sun, 03 Jul 2011)
Changed paths:
M variable.c
Log Message:
-----------
Make owl_variable_dict_newvar_* give accurate validsettings
Commit: fa981f3a5ef9ab1e4619fdbbfb0f3c142cffd2c7
https://github.com/barnowl/barnowl/commit/fa981f3a5ef9ab1e4619fdbbfb0f3c142cffd2c7
Author: Jason Gross <jgross@mit.edu>
Date: 2011-07-03 (Sun, 03 Jul 2011)
Changed paths:
M variable.c
Log Message:
-----------
Removed some NULL checks for things that really shouldn't ever be NULL
If a BarnOwl variable can't be gotten, then something is horribly wrong,
and if it can't be gotten as a string, then perl will be confused (and
something is probably horribly wrong anyway).
Additionally, our variable descriptions shoud be descriptive. Valid
settings should not be NULL (and NULL is more likely indicative of
forgetting to set it than actually wanting an empty valid set).
Commit: 785ee770a72bcdda39fd541a90d8c640fa5c76ca
https://github.com/barnowl/barnowl/commit/785ee770a72bcdda39fd541a90d8c640fa5c76ca
Author: Jason Gross <jgross@mit.edu>
Date: 2011-07-03 (Sun, 03 Jul 2011)
Changed paths:
M perl/lib/BarnOwl.pm
Log Message:
-----------
Allow zsigs to be '0'
Also, keep the feature that setting the zsig to '' will reset it to the
default.
Compare: https://github.com/barnowl/barnowl/compare/82e93c9...785ee77
