[1826] in BarnOwl Developers
Re: [PATCH 2/3] Add fill-paragraph test case for owl_editwin
daemon@ATHENA.MIT.EDU (David A Benjamin)
Thu Oct 29 18:22:48 2009
Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@lunatique.mit.edu
Date: Sat, 24 Oct 2009 13:07:23 -0400 (EDT)
From: David A Benjamin <davidben@MIT.EDU>
To: Nelson Elhage <nelhage@mit.edu>
cc: barnowl-dev@mit.edu
In-Reply-To: <20091024160606.GA21865@mit.edu>
Heh. Pushed. (More accurately, it was blocking on me having stuff to do
and then "Oh right, that thing.")
David
On Sat, 24 Oct 2009, Nelson Elhage wrote:
> I encourage you to commit the tests as you have them, and the bugfix,
> and then later fix the tests if you feel like it, rather than blocking
> the bugfix on rewriting the tests.
>
> - Nelson
>
> On Mon, Oct 19, 2009 at 09:09:33PM -0400, David A Benjamin wrote:
>> On Mon, 19 Oct 2009, Nelson Elhage wrote:
>>
>>> I would consider rewriting these tests to check that every line in the
>>> wrapped version is <= 80 characters in length, rather than checking
>>> the exact result.
>>
>> Sure. I think I'd prefer some check of content as well, so perhaps also
>> a check of a canonicalized string (convert string of whitespace to
>> single space or something) which should be fairly easy to generate.
>>
>> David
>>
>
