[1823] in BarnOwl Developers
Re: [PATCH 2/3] Add fill-paragraph test case for owl_editwin
daemon@ATHENA.MIT.EDU (Nelson Elhage)
Thu Oct 29 18:22:46 2009
Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@lunatique.mit.edu
Date: Sat, 24 Oct 2009 12:06:06 -0400
From: Nelson Elhage <nelhage@MIT.EDU>
To: David A Benjamin <davidben@mit.edu>
Cc: barnowl-dev@mit.edu
In-Reply-To: <alpine.DEB.1.10.0910192107270.7253@dr-wily.mit.edu>
I encourage you to commit the tests as you have them, and the bugfix,
and then later fix the tests if you feel like it, rather than blocking
the bugfix on rewriting the tests.
- Nelson
On Mon, Oct 19, 2009 at 09:09:33PM -0400, David A Benjamin wrote:
> On Mon, 19 Oct 2009, Nelson Elhage wrote:
>
> >I would consider rewriting these tests to check that every line in the
> >wrapped version is <= 80 characters in length, rather than checking
> >the exact result.
>
> Sure. I think I'd prefer some check of content as well, so perhaps also
> a check of a canonicalized string (convert string of whitespace to
> single space or something) which should be fairly easy to generate.
>
> David
>
