[1793] in BarnOwl Developers
Re: jabber-reconnect and irc-list-in-buddylist branches
daemon@ATHENA.MIT.EDU (Nelson Elhage)
Thu Oct 29 18:22:13 2009
Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@lunatique.mit.edu
Date: Sat, 17 Oct 2009 16:41:04 -0400
From: Nelson Elhage <nelhage@MIT.EDU>
To: Alex Vandiver <alex@chmrr.net>
Cc: barnowl-dev <barnowl-dev@mit.edu>
In-Reply-To: <1255631274-sup-8300@utwig>
[irc-list-in-buddylist]
Looks fine. My one comment is that
+ my ($nick, $server) = map $ircnets{$net}->$_, qw/nick server/;
Seems unnecessarily tricky. It took my a couple seconds to parse, and
I speak perl pretty fluently. I would be inclined to stick
$ircnet{$net} in a variable and just have something like
my ($nick, $server) = ($conn->nick, $conn->server);
[jabber-reconnect]
What happens if I log in to Jabber with tickets, and then get
disconnected after my tickets expire? I assume it should fail and keep
trying every 5 minutes, but I want to be sure it doesn't prompt for
your password or anything annoying like that.
Some nits:
+ $conn->setAuth( $jidStr => {%{ $vars{jlogin_authhash} }, password => $vars{jlogin_password}} );
I would break this line, and use a , instead of => after '$jidStr' --
I find it too easy to misread $jidStr as a key in the hash.
I'd like to see asedeno give this code at least a cursory look, since
he understands the Jabber code much better than I.
- Nelson
On Thu, Oct 15, 2009 at 02:35:59PM -0400, Alex Vandiver wrote:
> Heya,
> Per discussion on -c barnowl, we're trying to make new branches get
> announced for review on barnowl-dev@ for review. So:
>
> I just pushed irc-list-in-buddylist and jabber-reconnect branches to
> http://github.com/alexmv/barnowl . The former adds IRC servers and
> active channels to `blist` (similar to `irc-list`, of which I was not
> previously aware), the latter adds exponential-backoff auto-reconnect
> to jabber connections, for when servers keel over often.
> (*cough*mit.edu*cough*). Review appreciated.
> - Alex
> --
> Networking -- only one letter away from not working
