[1580] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[nelhage/barnowl] b600cf: save_excursion: Fix perl API error.

daemon@ATHENA.MIT.EDU (noreply@github.com)
Thu Oct 29 18:18:17 2009

Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@lunatique.mit.edu
Date: Sat, 25 Jul 2009 20:04:57 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com

Branch: refs/heads/tab-completion
Home:   http://github.com/nelhage/barnowl

Commit: b600cf76b5d81587df121b83089a946f430ee675
    http://github.com/nelhage/barnowl/commit/b600cf76b5d81587df121b83089a946f430ee675
Author: Nelson Elhage <nelhage@mit.edu>
Date:   2009-07-25 (Sat, 25 Jul 2009)

Changed paths:
  M perlglue.xs

Log Message:
-----------
save_excursion: Fix perl API error.

We need to save a mark and SPAGAIN around call_* macros. The old
behavior caused out-of-bounds stack dereferences and segfaults.


Commit: c29fe6569147986370d1a837ea6500de1825d28c
    http://github.com/nelhage/barnowl/commit/c29fe6569147986370d1a837ea6500de1825d28c
Author: Nelson Elhage <nelhage@mit.edu>
Date:   2009-07-25 (Sat, 25 Jul 2009)

Changed paths:
  M perl/lib/BarnOwl/Completion.pm

Log Message:
-----------
Implement tab completion by replacing the entire word.

Replace the entire word, instead of just appending the new text. Among
other things, this lets us deal with expansions that need to be quoted
much better.



home help back first fref pref prev next nref lref last post