[1546] in BarnOwl Developers
[nelhage/barnowl] 9de1dd: Simplify owl_function_expunge.
daemon@ATHENA.MIT.EDU (noreply@github.com)
Thu Oct 29 18:17:52 2009
Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@lunatique.mit.edu
Date: Sat, 11 Jul 2009 20:18:08 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/barnowl_perlmessages
Home: http://github.com/nelhage/barnowl
Commit: 9de1dd72dcf414a895b6aea0a2a33cc016862620
http://github.com/nelhage/barnowl/commit/9de1dd72dcf414a895b6aea0a2a33cc016862620
Author: Nelson Elhage <nelhage@mit.edu>
Date: 2009-07-11 (Sat, 11 Jul 2009)
Changed paths:
M functions.c
Log Message:
-----------
Simplify owl_function_expunge.
Iterators do the correct thing across message deletions, so there's no
reason to play the stupid save-the-message-id game. As a bonus, I
think this stops the point from moving around randomly on 'x'.
Commit: 7dd5bcbc704f35f745e378223534494bb44acb41
http://github.com/nelhage/barnowl/commit/7dd5bcbc704f35f745e378223534494bb44acb41
Author: Nelson Elhage <nelhage@mit.edu>
Date: 2009-07-11 (Sat, 11 Jul 2009)
Changed paths:
M functions.c
Log Message:
-----------
expunge: Don't let the point go off the message list.
Commit: de1818e0af452e4afde174a5f87337b9c6a3167e
http://github.com/nelhage/barnowl/commit/de1818e0af452e4afde174a5f87337b9c6a3167e
Author: Nelson Elhage <nelhage@mit.edu>
Date: 2009-07-11 (Sat, 11 Jul 2009)
Changed paths:
M mainwin.c
Log Message:
-----------
Add a check in case the point does ends up off the messagelist.
I believe the previous commit /should/ enforce the invariant that the
point never points past the last message, unless the message list is
empty. However, add an explicit check for it, since with the current
code, violating that invariant will result in a segfault.
