[1495] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[nelhage/barnowl] 404de3: Replace '@ISA' references with 'use base'

daemon@ATHENA.MIT.EDU (noreply@github.com)
Thu Oct 29 18:17:13 2009

Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@lunatique.mit.edu
Date: Wed, 3 Jun 2009 12:24:56 -0700
To: barnowl-dev@mit.edu
From: noreply@github.com

Branch: refs/heads/barnowl_perlmessages
Home:   http://github.com/nelhage/barnowl

Commit: 404de3f2ce8c8933937ed16b91b2121701da8d32
    http://github.com/nelhage/barnowl/commit/404de3f2ce8c8933937ed16b91b2121701da8d32
Author: Nelson Elhage <nelhage@mit.edu>
Date:   2009-06-03 (Wed, 03 Jun 2009)

Changed paths:
  M perl/lib/BarnOwl/Style/Basic.pm
  M perl/lib/BarnOwl/Style/OneLine.pm

Log Message:
-----------
Replace '@ISA' references with 'use base'

'use base' will automatically 'use' the prereq modules, which was
potentially problematic back when that didn't work, but is now exactly
what we want.


Commit: 649211034b4866ebdaeac902daabb23893abf2fa
    http://github.com/nelhage/barnowl/commit/649211034b4866ebdaeac902daabb23893abf2fa
Author: Nelson Elhage <nelhage@mit.edu>
Date:   2009-06-03 (Wed, 03 Jun 2009)

Changed paths:
  M t/message-list.t
  M t/messages.t
  M t/mock.pl

Log Message:
-----------
Add some basic tests for messages and the message list.

t/mock.pl mocks enough of perlglue.xs to load our code without loading
barnowl itself, so that we can test things in perl code.


Commit: bdaa55b4c78d4e6558e1cb387821ca8d80ccbd99
    http://github.com/nelhage/barnowl/commit/bdaa55b4c78d4e6558e1cb387821ca8d80ccbd99
Author: Nelson Elhage <nelhage@mit.edu>
Date:   2009-06-03 (Wed, 03 Jun 2009)

Changed paths:
  M perl/lib/BarnOwl/MessageList.pm

Log Message:
-----------
Fix a bug in BarnOwl::MessageList::binsearch

The (failing) tests in the previous commit unmask a bug in binsearch,
where it would sometimes return an incorrect index. Fix that bug.


Commit: dc5cc5699fb3eea21ac67fef8eba421b74b70577
    http://github.com/nelhage/barnowl/commit/dc5cc5699fb3eea21ac67fef8eba421b74b70577
Author: Nelson Elhage <nelhage@mit.edu>
Date:   2009-06-03 (Wed, 03 Jun 2009)

Changed paths:
  M perl/lib/BarnOwl/MessageList.pm
  M t/message-list.t

Log Message:
-----------
More message list tests, and clean up the message list API.

More strictly define the iterate_* message list API, document it, and add
tests that it behaves as documented.


Commit: 659b9988e100d1853b7347963d9af424d7ba774d
    http://github.com/nelhage/barnowl/commit/659b9988e100d1853b7347963d9af424d7ba774d
Author: Nelson Elhage <nelhage@mit.edu>
Date:   2009-06-03 (Wed, 03 Jun 2009)

Changed paths:
  M perl/lib/BarnOwl/MessageList.pm

Log Message:
-----------
Don't try to load the SQL message list.

At some point I'll bring back the SQL message list, but at this point,
this branch is just for developing the in-perl message store APIs and
use of them. So, as long as we don't have a SQL message list, don't
ask for it.



home help back first fref pref prev next nref lref last post