[10632] in The GTK GIMP ToolKit mailing list archive

home help back first fref pref prev next nref lref last post

[gtk-list] gtk--: patch to signal.disconnect (prevents list corruption)

daemon@ATHENA.MIT.EDU (Christof Petig)
Thu Dec 3 06:11:45 1998

Date: Thu, 03 Dec 1998 12:09:49 +0100
From: Christof Petig <christof.petig@wtal.de>
To: Gtk-List <gtk-list@redhat.com>
Resent-From: gtk-list@redhat.com
Reply-To: gtk-list@redhat.com

This is a multi-part message in MIME format.
--------------2F4015667DD4C5DB8C637C84
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Quoting from my attempted cvs log:

* gtk--sigcommon.h:

   changed disconnect to nullify pointers on disconnect.
   It took me hours of debugging nightmares (now for the second time)
   to trace a doubled disconnect. Now it is silently ignored
   - this is much better than silently trashing the connection list.


Christof

PS: Would you change this? (I'm user christof on cvs.gnome.org)
cvs [server aborted]: "commit" requires write access to the repository
cvs commit: saving log message in /tmp/cvs30489baa


--------------2F4015667DD4C5DB8C637C84
Content-Type: text/plain; charset=us-ascii; name="patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="patch"

*** gtk--sigcommon.h~	Mon Nov 16 14:34:56 1998
--- gtk--sigcommon.h	Thu Dec  3 11:59:11 1998
*************** public:
*** 96,105 ****
--- 96,107 ----
  	if (next) { 
  	    next->prev=prev;
  	    prev->next=next;
+ 	    next=prev=0;
  	}
  	if (snext) {
  	    snext->sprev=sprev;
  	    sprev->snext=snext;
+ 	    snext=sprev=0;
  	}
  #ifndef GTKMM_SIGNALS_WITHOUT_GTK
  	if (gtkobj) {

--------------2F4015667DD4C5DB8C637C84--

-- 
To unsubscribe: mail -s unsubscribe gtk-list-request@redhat.com < /dev/null


home help back first fref pref prev next nref lref last post