[9313] in linux-scsi channel archive
Re: TYPE_COMM not being used in the kernel source
daemon@ATHENA.MIT.EDU (Kurt Garloff)
Mon Aug 7 09:26:00 2000
Date: Mon, 7 Aug 2000 15:18:11 +0200
From: Kurt Garloff <garloff@suse.de>
To: Kees Cook <cook@cpoint.net>
Cc: Linux SCSI list <linux-scsi@vger.rutgers.edu>
Message-ID: <20000807151811.N27907@garloff.etpnet.phys.tue.nl>
Mail-Followup-To: Kurt Garloff <garloff@suse.de>,
Kees Cook <cook@cpoint.net>,
Linux SCSI list <linux-scsi@vger.rutgers.edu>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
protocol="application/pgp-signature"; boundary="i6vqABX3nJKXLk01"
Content-Disposition: inline
In-Reply-To: <20000805181135.A7873@cpoint.net>; from cook@cpoint.net on Sat, Aug 05, 2000 at 06:11:35PM -0500
--i6vqABX3nJKXLk01
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Aug 05, 2000 at 06:11:35PM -0500, Kees Cook wrote:
> Type: Communications ANSI SCSI revision: 02
> ncr53c875-0-<0,0>: tagged command queue depth set to 8
> resize_dma_pool: unknown device type 9
> >From looking through the linux kernel code, I notice that in
> include/scsi/scsi.h, "TYPE_COMM" is not specified. However, in
> drivers/scsi/tmscsim.h and advansys.c, it is. No device appears to
> actually USE these defines, and in scsi.c, the 9th type in
> "scsi_device_types" IS written in as "Communications".
>=20
> Therefore, I'd conclude that the missing definition in include/scsi/scsi.h
> is simply just the case that no one has or uses these devices, especially
> since the "scsi_devices_types" array is populated with the information,
> I'd argue that "TYPE_COMM" *should* be included in scsi.h.
It should. As should TYPE_PRINTER.
Please add them both to include/scsi/scsi.h
(even if you don't use the TYPE_PRINTER for anything).
Regards,
--=20
Kurt Garloff <garloff@suse.de> Eindhoven, NL
GPG key: See mail header, key servers Linux kernel development
SuSE GmbH, Nuernberg, FRG SCSI, Security
--i6vqABX3nJKXLk01
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1e-SuSE (GNU/Linux)
Comment: Weitere Infos: siehe http://www.gnupg.org
iD8DBQE5jrcSxmLh6hyYd04RAh13AJ9D3Rawb5UPKanm4NtmkGlKraygsgCeLmDT
jOqzk2MeaNc4Uu1RPLh7yD8=
=v2/g
-----END PGP SIGNATURE-----
--i6vqABX3nJKXLk01--
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu
