[8443] in linux-scsi channel archive
Re: DMX3191D patch
daemon@ATHENA.MIT.EDU (Alan Cox)
Tue Mar 21 19:54:17 2000
To: unfarco@tiscalinet.it (Massimo Piccioni)
Date: Tue, 21 Mar 2000 19:48:48 +0000 (GMT)
Cc: linux-scsi@vger.rutgers.edu
In-Reply-To: <38D7997F.89FAF0D0@tiscalinet.it> from "Massimo Piccioni" at Mar 21, 2000 04:47:11 PM
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <E12XUe2-0005OE-00@the-village.bc.nu>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> attached is the dmx3191d-patch in diff uni format from 2.3.51 kernel
> source
> let me know if something is wrong
Looks basically ok to me.
I see a couple of minor items
o You aren't allowed to have a dev_id of NULL when using SA_SHIRQ. I'd
suggest using instance
o You request the IRQ before you configure the driver. If the irq line
is shared you may hang the machine
I would suggest the following small changes
Move the request_irq to after the NCR5380_init (I assume NCR5380_init doesnt
need the IRQ ?). Pass it instance as the argument. Pass instance to free_irq()
as well.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu
