[8366] in linux-scsi channel archive
Re: 2.3.51, CD-ROM, and REQUEST_SENSE
daemon@ATHENA.MIT.EDU (Jens Axboe)
Tue Mar 14 21:00:38 2000
Date: Tue, 14 Mar 2000 20:27:35 +0100
From: Jens Axboe <axboe@suse.de>
To: Matthew Dharm <mdharm-scsi@one-eyed-alien.net>
Cc: The Linux SCSI list <linux-scsi@vger.rutgers.edu>
Message-ID: <20000314202735.T7386@suse.de>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="9jxsPFA5p3P2qPhR"
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.10.10003141118120.8501-100000@ziggy.one-eyed-alien.net>; from mdharm-scsi@one-eyed-alien.net on Tue, Mar 14, 2000 at 11:20:17AM -0800
--9jxsPFA5p3P2qPhR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Tue, Mar 14 2000, Matthew Dharm wrote:
> Unfortunately, for USB Mass Storage, getting an accurate idea of how much
> data there is to transfer (especially for commands that can only transfer
> a fixed amount of information) is very important. So far, this is the
> only case I've found where it's wrong, and I'm afraid I don't have the
> time to discover where is is going wrong before 2.4.0
This must be a loose requirement, I hope.
> Would someone who is more familiar with these layer (Eric? someone else?)
> please fix this? And let me know when you do so I can test it. I imagine
> that it's probably, as you indicate, just a quick little fix to some relic
> code. Hopefully we can get this in before 2.4.0
Ok, fixes attached for sr to set transfer length correctly for READ_CAPACITY.
SD already does this correctly.
I assume that you meant CD-ROM then?
--
* Jens Axboe <axboe@suse.de>
* Linux CD-ROM Maintainer
* http://www.kernel.dk
--9jxsPFA5p3P2qPhR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="sr_cap.diff"
--- sr.c~ Tue Mar 14 21:22:20 2000
+++ sr.c Tue Mar 14 21:22:37 2000
@@ -498,7 +498,7 @@
SRpnt->sr_data_direction = SCSI_DATA_READ;
scsi_wait_req(SRpnt, (void *) cmd, (void *) buffer,
- 512, SR_TIMEOUT, MAX_RETRIES);
+ 8, SR_TIMEOUT, MAX_RETRIES);
the_result = SRpnt->sr_result;
retries--;
--9jxsPFA5p3P2qPhR--
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu
