[7835] in linux-scsi channel archive
Re: [Question] rscsi_disks[].device being NULL
daemon@ATHENA.MIT.EDU (Guest section DW)
Sun Jan 16 04:53:04 2000
Message-ID: <20000116043358.A18635@win.tue.nl>
Date: Sun, 16 Jan 2000 04:33:58 +0100
From: Guest section DW <dwguest@win.tue.nl>
To: Alexander Viro <viro@math.psu.edu>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-scsi@vger.rutgers.edu
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <Pine.GSO.4.10.10001140353100.853-100000@weyl.math.psu.edu>; from Alexander Viro on Fri, Jan 14, 2000 at 04:02:32AM -0500
On Fri, Jan 14, 2000 at 04:02:32AM -0500, Alexander Viro wrote:
> ... how can it happen in revalidate_scsidisk()? Immediately before
> checking for it we do scsi_init_onedisk(target); and this one would die
> horrible death if rscsi_disk[target].device was NULL. So either it's too
> late or it is always false.
Right.
(And if I am not mistaken rscsi_disks[].device is only set
to zero in sd_detach(), called by the proc code and by
scsi_unregister_host() and scsi_unregister_device() in scsi.c.)
Another triviality to remove:
sd_init_command() {
...
dpnt = &rscsi_disks[dev];
if (!dpnt) ...
Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu
