[7744] in linux-scsi channel archive
Re: Bug at spinlock.h line 92
daemon@ATHENA.MIT.EDU (Manfred Spraul)
Fri Dec 24 04:36:58 1999
Message-ID: <38633CDD.CDADBD1@colorfullife.com>
Date: Fri, 24 Dec 1999 10:29:01 +0100
From: Manfred Spraul <manfreds@colorfullife.com>
MIME-Version: 1.0
To: torvalds@transmeta.com, linux-scsi@vger.rutgers.edu
Cc: German Jose Gomez Garcia <german@pinon.ccu.uniovi.es>,
Tigran Aivazian <tigran@sco.COM>,
"Steven N. Hirsch" <shirsch@adelphia.net>,
linux-kernel@vger.rutgers.edu
Content-Type: multipart/mixed;
boundary="------------2BD3E2393FAA03AD3D5849FE"
This is a multi-part message in MIME format.
--------------2BD3E2393FAA03AD3D5849FE
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
German Jose Gomez Garcia wrote:
> >
> > The request function of your hardware device driver returned without
> > owning the io_request_lock.
>
> It is a SCSI ZIP disk attached to an onboard AIC7890 (included in a
> Supermicro PDBU motherboard)
>
I could reproduce it too:
* sym53810 [compiled as module]
* Iomega ZIP [no disk inserted]
* scsi midlayer statically linked into the kernel
if I start "modprobe sym53c8xx", then the kernel causes an oops.
The patch below fixes the problem.
german, could you try the patch below?
--
Manfred
--------------2BD3E2393FAA03AD3D5849FE
Content-Type: text/plain; charset=us-ascii;
name="patch-scsi"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="patch-scsi"
--- 2.3/drivers/scsi/scsi_lib.c Tue Dec 21 09:35:12 1999
+++ build-2.3/drivers/scsi/scsi_lib.c Fri Dec 24 09:50:00 1999
@@ -821,12 +821,14 @@
* get those allocated here.
*/
if (!SDpnt->scsi_init_io_fn(SCpnt)) {
+ spin_lock_irq(&io_request_lock);
continue;
}
/*
* Initialize the actual SCSI command for this request.
*/
if (!STpnt->init_command(SCpnt)) {
+ spin_lock_irq(&io_request_lock);
continue;
}
}
--------------2BD3E2393FAA03AD3D5849FE--
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu
