[764] in linux-scsi channel archive
Re: Patch for st.c (1.1.37)
daemon@ATHENA.MIT.EDU (Kai Makisara)
Sat Nov 4 22:23:09 1995
Date: Sat, 4 Nov 1995 21:04:03 +0200 (EET)
From: Kai Makisara <makisara@abies.metla.fi>
Reply-To: Kai.Makisara@metla.fi
To: Stefan Voigt <voigt@pirx.franken.de>
Cc: linux-scsi@vger.rutgers.edu
In-Reply-To: <Pine.LNX.3.91.951102204222.582A-100000@pirx.franken.de>
On Thu, 2 Nov 1995, Stefan Voigt wrote:
> Hello,
>
> with 1.3.36 and 1.3.37 i have seen some kernel-oops. I tracked
> this down to an NULL-pointer, being dereferenced in st_do_scsi.
...
> The cause is the st_sleep_done function, which in line 191 "up"s the
> semaphore pointed to and then assigns NULL to the pointer !!
> Please, will someone with better knowledge of the scsi code than me,
> check that the patch is the correct solution.
>
The bug is setting SCpnt->request.sem = NULL in st_sleep_done. You can
just remove that statement. It is not necessary and, as you have noticed,
it is harmful in some systems.
Kai
