[7229] in linux-scsi channel archive
Re: compile warning
daemon@ATHENA.MIT.EDU (Douglas Gilbert)
Fri Sep 17 22:50:18 1999
Message-ID: <37E2D3F7.EC72A8AB@interlog.com>
Date: Fri, 17 Sep 1999 19:51:19 -0400
From: Douglas Gilbert <dgilbert@interlog.com>
MIME-Version: 1.0
To: Geert Uytterhoeven <geert@sonycom.com>
CC: linux-scsi@vger.rutgers.edu
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Geert Uytterhoeven wrote:
>
> Is this fix OK (for vger-now)?
>
> Index: drivers/scsi/scsi.c
> ===================================================================
> RCS file: /vger/u4/cvs/linux/drivers/scsi/scsi.c,v
> retrieving revision 1.91
> diff -u -r1.91 scsi.c
> --- scsi.c 1999/09/10 10:42:40 1.91
> +++ scsi.c 1999/09/16 18:35:30
> @@ -3244,7 +3244,7 @@
> }
> }
> }
> - printk("wait_for_request = %p\n", wait_for_request);
> + printk("wait_for_request = %p\n", &wait_for_request);
> #endif /* CONFIG_SCSI_LOGGING */ /* } */
> #endif /* CONFIG_PROC_FS */
> }
>
A similar patch is already in place in 2.3.18ac5 . That
patch goes a step further and comments out that line.
That line will only be printing out the address of an
global variable which is of little interest when trying
to debug a SCSI problem. Perhaps there may be something
a little more sensible to print out about that wait
queue?
Doug Gilbert
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu
