[7152] in linux-scsi channel archive
Re: Fixing the SCSI layer
daemon@ATHENA.MIT.EDU (Kurt Garloff)
Sun Sep 5 16:40:58 1999
Date: Sun, 5 Sep 1999 22:38:26 +0200
From: Kurt Garloff <garloff@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux SCSI list <linux-scsi@vger.rutgers.edu>
Mail-Followup-To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux SCSI list <linux-scsi@vger.rutgers.edu>
In-Reply-To: <E11NFyZ-0006X3-00@the-village.bc.nu>; from Alan Cox on Sat, Sep 04, 1999 at 02:35:24PM +0100
--mP3DRpeJDSE+ciuQ
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
On Sat, Sep 04, 1999 at 02:35:24PM +0100, Alan Cox wrote:
> The scsi code however is so hard to read its going to be quicker to clean
> it up and fix bits than to try and debug it further. Is anyone else trying
> to clean up the scsi mess currently.
>=20
> I'm not going to write some new scsi layer, sorry someone crazier can do =
that
> just to clean up the cruft, including stuff like banging it all through
> indent and extracting common code into functions, moving long complex con=
ditional
> code into functions etc.
>=20
> I'd appreciate a couple of eyeballs over the following first small patches
> to extract 'do a command and wait for it'
You introduce a scsi_wait_cmd() and call it instead of putting the insns
there. Only change: spin_lock_irqsave and _irqrestore instead of _irq.
Certainly correct.
In sd, you also correct a jiffie comaparison: OK.
In short: Looks fine to me.
--=20
Kurt Garloff <garloff@suse.de> Wuppertal, FRG
PGP2 key: See mail header, key servers Linux kernel development
SuSE GmbH, N=FCrnberg, FRG SCSI drivers: tmscsim(DC390), DC395
--mP3DRpeJDSE+ciuQ
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i
iQCVAwUBN9LUwhaQN/7O/JIVAQHrdQQAmcDktbfUy1vZ1PARfTE0DDZqPqdUP+oG
ziVQ4CK9kYtVn+PjFwD5PyPwBOg2RPAmymBccdYnerfIdE9qxGW9nmgPOLp7UGPa
XULARsCWAmN2d72TIk5birxwvigOqOwa0kEEg3seZxkbFLmI53nu8SbaWahG8Yy8
LE2InreXxxQ=
=NtDz
-----END PGP SIGNATURE-----
--mP3DRpeJDSE+ciuQ--
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu
